Bug 495809 - Some Tool Options panels have extra whitespace at the bottom
Summary: Some Tool Options panels have extra whitespace at the bottom
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Dockers (show other bugs)
Version: 5.2.3
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-05 02:29 UTC by i
Modified: 2024-11-07 15:49 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot showing bug (24.77 KB, image/png)
2024-11-05 02:29 UTC, i
Details

Note You need to log in before you can comment on or make changes to this bug.
Description i 2024-11-05 02:29:39 UTC
Created attachment 175529 [details]
Screenshot showing bug

SUMMARY
The Move and Transform tools' Tool Options panels, when shown in the Docker, have extra whitespace at the bottom which forces a scrollbar to appear in some cases.

STEPS TO REPRODUCE
Open "Tool Options Docker" with the Move or Transform tool selected, with height of the docker set to be able to see all elements

OBSERVED RESULT
There is a large amount of whitespace below the last checkbox, which necessitates a scrollbar, which scrolls down to see nothing.

EXPECTED RESULT
This whitespace does not exist, nor does the scrollbar appear.

SOFTWARE/OS VERSIONS
Operating System: Fedora Linux 41
KDE Plasma Version: 6.2.2
KDE Frameworks Version: 6.7.0
Qt Version: 6.8.0
Kernel Version: 6.11.5-300.fc41.x86_64 (64-bit)
Graphics Platform: Wayland

ADDITIONAL INFORMATION
Screenshot of Move Tool attached. Also occurs for the Transform Tool.
You can also see in this screenshot a separate text bug, where the ends of the text are cut off needlessly.
Comment 1 i 2024-11-05 04:25:10 UTC
This also happens with the Specific Colour Selector, kinda. It doesn't pop up a scroll bar, but when being shrunk vertically, it does pre-maturely "bunch up" the elements vertically when there's whitespace still available.
Comment 2 Halla Rempt 2024-11-05 14:04:00 UTC
I can confirm this, but we've spent many days in the past tweaking these panels and nobody wants to look at this code again until we start rewriting the dockers...
Comment 3 Dmitry Kazakov 2024-11-07 15:49:39 UTC
Git commit 7bc7be7f8c1743e11a27fbe88856edcb394bc545 by Dmitry Kazakov.
Committed on 07/11/2024 at 15:49.
Pushed by dkazakov into branch 'master'.

Remove extra 40 px spacers at the bottom of Transform, Move and Crop tool options

M  +16   -4    plugins/tools/basictools/wdgmovetool.ui
M  +29   -29   plugins/tools/tool_crop/wdg_tool_crop.ui
M  +35   -11   plugins/tools/tool_transform2/wdg_tool_transform.ui

https://invent.kde.org/graphics/krita/-/commit/7bc7be7f8c1743e11a27fbe88856edcb394bc545