Bug 495737 - Closing Manual Rotator dialog after rotation validation is complete aborts alignment
Summary: Closing Manual Rotator dialog after rotation validation is complete aborts al...
Status: RESOLVED FIXED
Alias: None
Product: kstars
Classification: Applications
Component: general (other bugs)
Version First Reported In: 3.7.3
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Jasem Mutlaq
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-03 05:19 UTC by Jon Dalrymple
Modified: 2024-11-03 14:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 3.7.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Dalrymple 2024-11-03 05:19:54 UTC
SUMMARY
When using the Manual Rotator dialog to rotate my camera to match a required PA, there is no way to close the dialog after the rotation validation is complete. Clicking "Cancel" or the "X" both cause the Alignment procedure to be aborted.

STEPS TO REPRODUCE
1. Ensure "Automatic and Manual Rotator Control" is enabled under Ekos->Alignment->Options->StellarSolver Options.
2. Attempt alignment procedure where a certain PA is required (e.g. scheduled mosaic, matching plate-solved reference image)
3. The Manual Rotator dialog appears. The camera can be rotated, "Take Another Image" can be clicked, and the dialog works accordingly.
4. Once the PA threshold has been reached, the Manual Rotator dialog shows a green "OK" icon.
5. Closing the dialog now aborts the alignment procedure.

OBSERVED RESULT
Closing the Manual Rotator dialog after PA threshold is reached aborts the alignment procedure.

EXPECTED RESULT
If the PA threshold isn't reached, abort the alignment procedure upon closing the dialog.
If the PA threshold is reached, closing the dialog should do nothing.

SOFTWARE/OS VERSIONS
Armbian 24.5.1 Jammy
Kstars 3.7.3

ADDITIONAL INFORMATION
As a workaround, keeping the dialog open/folded seems to work. It might be possible to close it well after alignment is finished (e.g. after starting a capture sequence), but I still see a "Capture Aborted" message appear in the Alignment tab after the dialog is closed.
Comment 1 Jon Dalrymple 2024-11-03 05:24:22 UTC
(In reply to Jon Dalrymple from comment #0)
> but I still see a "Capture Aborted" message appear in the
> Alignment tab after the dialog is closed.
My apologies: I meant to say "Solver Aborted", not "Capture Aborted"
Comment 2 Jasem Mutlaq 2024-11-03 14:14:53 UTC
Git commit 3f1af21a6589e96b89a84cad953d13353473756a by Jasem Mutlaq.
Committed on 03/11/2024 at 09:41.
Pushed by mutlaqja into branch 'master'.

If manual rotator is complete, do not abort solver.
FIXED-IN:3.7.4

M  +3    -1    kstars/ekos/align/align.cpp

https://invent.kde.org/education/kstars/-/commit/3f1af21a6589e96b89a84cad953d13353473756a