Bug 495553 - Filelight installer unconditionally uses PackageKit, which doesn't work when the distro has no PackageKit support
Summary: Filelight installer unconditionally uses PackageKit, which doesn't work when ...
Status: CONFIRMED
Alias: None
Product: dolphin
Classification: Applications
Component: bars: status (show other bugs)
Version: 24.08.2
Platform: Flatpak Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-29 22:12 UTC by Nate Graham
Modified: 2025-01-22 21:44 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-10-29 22:12:40 UTC
STEPS TO REPRODUCE
1. Use a distro with no PackageKit support, for example: KDE Linux, SteamOS, Fedora Kinoite, or OpenSuse Kalpa
2. Don't have Filelight installed
3. Open Dolphin
4. Click on the button on the status bar that shows Filelight-related free space investigation options when it's installed, and an option to install it when it's not installed
5. See that it has an "Install Filelight…" button and click it

OBSERVED RESULT
Dolphin shows "Installing Filelight…" and an indeterminate progess bar, but it never succeeds at installing Filelight.

EXPECTED RESULT
when PackageKit isn't available, either don't show this functionality, or else try alternative installation methods, such as Flatpak or Snap.

ADDITIONAL INFORMATION
When Filelight is installed manually from Flathub, the menu entries I would expect to see in Dolphin appear as expected
Comment 1 David Edmundson 2024-10-31 14:47:05 UTC
This is not entirely true, it's defined at build time, without packagekit dolphin falls back to opening a URL. 

A runtime check could be better

But really shouldn't this all be 

openUrl("appstream:org.kde.filelight.desktop

and let Discover take care of all these details? Then we can kill a few hundred lines and be better and support flatpak.
Comment 2 Nicolas Fella 2025-01-22 20:28:38 UTC
> But really shouldn't this all be 
>
> openUrl("appstream:org.kde.filelight.desktop
>
> and let Discover take care of all these details? Then we can kill a few hundred lines and be better and support flatpak.

it was when I wrote it, but then someone "Improved the UX "
Comment 3 Nate Graham 2025-01-22 21:44:45 UTC
It is an improvement when Filelight is available via PackageKit. When it's not, we should just go back to the older and simpler approach, yeah.