Bug 495444 - [Desktop Bar] Dropped windows "glide" offscreen
Summary: [Desktop Bar] Dropped windows "glide" offscreen
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-overview (show other bugs)
Version: 6.2.2
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-10-27 19:29 UTC by Blazer Silving
Modified: 2024-11-09 18:17 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.4
Sentry Crash Report:


Attachments
Desktop bar behavior in 6.1.5 (2.37 MB, video/mp4)
2024-10-27 19:30 UTC, Blazer Silving
Details
Desktop bar behavior in 6.2.0 (2.25 MB, video/mp4)
2024-10-27 19:30 UTC, Blazer Silving
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Blazer Silving 2024-10-27 19:29:27 UTC
SUMMARY
Noticed a regression with the desktop bar as of 6.2, windows dragged into the desktop bar pop and glide when dragged to a target desktop. Can reproduce on X11 and Wayland with two linear desktops, recordings attached.

STEPS TO REPRODUCE
1. Sign into new session (X11/Wayland)
2. Engage Overview (Meta+W) and add a second Virtual Desktop in the Desktop Bar
3. Drag and drop a window to the second desktop using the bar.
4. Observe the window behavior, where it originates in the thumbnail and "glides" offscreen.

OBSERVED RESULT
Windows "glide" offscreen to their target desktop. 

EXPECTED RESULT
Windows should "sink into" or otherwise stay in the target thumbnail, not glide to the actual target itself. 

SOFTWARE/OS VERSIONS
KDE Plasma Version: 6.2.2
KDE Frameworks Version: 6.7.0
Qt Version: 6.8.0

ADDITIONAL INFORMATION

Looks like the work from https://invent.kde.org/plasma/kwin/-/commit/01d7ddff68e9e616bbcfca2bedce0741d57a3500 is the cause, not sure how I didn't notice this in testing earlier this month. The refactored ExpoLayout otherwise seems to behave as expected. 

I'm thinking the fix may lie in:
src/plugins/overview/qml/DesktopBar.qml
src/plugins/private/qml/WindowHeapDelegate.qml
Comment 1 Blazer Silving 2024-10-27 19:30:27 UTC
Created attachment 175283 [details]
Desktop bar behavior in 6.1.5
Comment 2 Blazer Silving 2024-10-27 19:30:51 UTC
Created attachment 175284 [details]
Desktop bar behavior in 6.2.0
Comment 3 Nate Graham 2024-10-28 01:46:50 UTC
Can reproduce.
Comment 4 Bug Janitor Service 2024-11-07 14:44:43 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6747
Comment 5 Marco Martin 2024-11-07 16:23:44 UTC
Git commit 2e0b33eae4588a829e64495efbb27a25da311190 by Marco Martin.
Committed on 07/11/2024 at 16:04.
Pushed by mart into branch 'master'.

effects/overview: Don't make thumbnails fly off the screen

When dropping a thumbnail on another desktop, don't animate the
position, otherwise we see the window oddly flying off the screen
to go on its new position on the different desktop

M  +9    -0    src/plugins/private/qml/WindowHeapDelegate.qml

https://invent.kde.org/plasma/kwin/-/commit/2e0b33eae4588a829e64495efbb27a25da311190
Comment 6 Blazer Silving 2024-11-09 18:17:14 UTC
Confirmed fixed, thanks y'all!