Bug 495256 - A single-line SelectableLabel's implicitHeight is too tall now
Summary: A single-line SelectableLabel's implicitHeight is too tall now
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: Master
Platform: Other Linux
: NOR normal
Target Milestone: Not decided
Assignee: kdelibs bugs
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-10-23 18:24 UTC by Nate Graham
Modified: 2024-10-23 21:34 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kirigami/-/commit/9738ae7ab7d823630f7ea475673f9c8cc8c65dce
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Lines are too tall now (1.11 MB, image/png)
2024-10-23 18:24 UTC, Nate Graham 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-10-23 18:24:49 UTC 
Created attachment 175155 [details]
Lines are too tall now

See attached screenshot for the effect in Info Center.
Comment 1 Bug Janitor Service 2024-10-23 19:13:25 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1648
Comment 2 Nate Graham 2024-10-23 21:34:48 UTC 
Git commit 9738ae7ab7d823630f7ea475673f9c8cc8c65dce by Nate Graham.
Committed on 23/10/2024 at 21:20.
Pushed by ngraham into branch 'master'.

SelectableLabel: override default padding values more completely

It was already setting padding to 0, but that doesn't override the
individual top/left/right/bottom properties. We need to do those too,
and also set them to undefined instead of 0 to make it easier for users
of the control to re-add padding if they want.

M  +6    -1    src/controls/SelectableLabel.qml

https://invent.kde.org/frameworks/kirigami/-/commit/9738ae7ab7d823630f7ea475673f9c8cc8c65dce