Bug 494721 - black and white, symbolic version of the folder-rpm-synbolic icon for Discover
Summary: black and white, symbolic version of the folder-rpm-synbolic icon for Discover
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (other bugs)
Version First Reported In: 6.2.0
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-14 08:04 UTC by Timothée Ravier
Modified: 2024-10-21 15:37 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.8
Sentry Crash Report:


Attachments
Discover window and icon picker searching for rpm (90.54 KB, image/png)
2024-10-14 08:04 UTC, Timothée Ravier
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timothée Ravier 2024-10-14 08:04:08 UTC
Created attachment 174793 [details]
Discover window and icon picker searching for rpm

SUMMARY

To get a uniform look, we'll need a black and white, symbolic version of the rpm icon that is currently used in Discover for the rpm-ostree category. See details in the screenshot.

STEPS TO REPRODUCE
1. Open latest Discover on Fedora Kinoite

OBSERVED RESULT

Colored icon for Operating System section

EXPECTED RESULT

Black & white icon

SOFTWARE/OS VERSIONS
Operating System: Fedora Linux 41
KDE Plasma Version: 6.2.0
KDE Frameworks Version: 6.7.0
Qt Version: 6.7.2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2024-10-16 18:12:32 UTC
Arguably, the right approach here would be to make all the "folder-*-symbolic" icons be black. Most already are, but some use a different color inherited from the non-symbolic version. This is probably fine for the small sizes of the non-symbolic icon, but not for icons explicitly requested in symbolic form.

Icons that would need this "make it black" treatment are:
- folder-android-symbolic
- folder-blender-symbolic
- folder-crash-symbolic
- folder-important-symbolic
- folder-java-symbolic
- folder-podcast-symbolic
- folder-rpm-symbolic

There are also a few symbolic folder icons that are not actually symbolic at all that I noticed in the process:
- folder-deb-symbolic
- folder-trash-symbolic
Comment 2 Bug Janitor Service 2024-10-16 21:13:39 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/410
Comment 3 Nate Graham 2024-10-21 15:37:17 UTC
Git commit 19cd41e649f664268f55874bafeffdabffcaad0d by Nate Graham.
Committed on 21/10/2024 at 15:23.
Pushed by ngraham into branch 'master'.

Monochromize not-explicitly-colorized symbolic folder icons

We have symbolic versions of folder icons, but currently they're all
just symlinks to the 16px and 22px versions of the base icon. Most of
the time this is fine.

Some of those folder icons are not monochrome at those sizes, though;
they intentionally retain their color. This is normally fine, but not
desired for symbolic icons, where we want to expunge as much color as
possible — except for the folder icons that are explicitly and
intentionally colored that way.
FIXED-IN: 6.8

T  +14   -1    icons/places/16/folder-android-symbolic.svg
T  +14   -1    icons/places/16/folder-blender-symbolic.svg
T  +14   -1    icons/places/16/folder-crash-symbolic.svg
T  +14   -1    icons/places/16/folder-important-symbolic.svg
T  +14   -1    icons/places/16/folder-java-symbolic.svg
T  +14   -1    icons/places/16/folder-podcast-symbolic.svg
T  +14   -1    icons/places/16/folder-rpm-symbolic.svg
T  +14   -1    icons/places/22/folder-android-symbolic.svg
T  +14   -1    icons/places/22/folder-blender-symbolic.svg
T  +14   -1    icons/places/22/folder-crash-symbolic.svg
T  +14   -1    icons/places/22/folder-important-symbolic.svg
T  +14   -1    icons/places/22/folder-java-symbolic.svg
T  +14   -1    icons/places/22/folder-podcast-symbolic.svg
T  +14   -1    icons/places/22/folder-rpm-symbolic.svg

https://invent.kde.org/frameworks/breeze-icons/-/commit/19cd41e649f664268f55874bafeffdabffcaad0d