Bug 494670 - K3B compile fails with; useProxy' is not a member of KProtocolManager
Summary: K3B compile fails with; useProxy' is not a member of KProtocolManager
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: general (show other bugs)
Version: 24.08.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: k3b developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-13 15:11 UTC by Taurnil
Modified: 2024-10-13 23:58 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Taurnil 2024-10-13 15:11:12 UTC
SUMMARY


STEPS TO REPRODUCE
1. compile qt6-6.8.0
2. compile frameworks 6.7.0
3. compile any additonal dependencies/or optional for k3b

OBSERVED RESULT
[ 35%] Built target k3blib
[ 35%] Built target k3b_autogen_timestamp_deps
[ 36%] Built target k3b_autogen
[ 36%] Building CXX object src/CMakeFiles/k3b.dir/k3btrm.cpp.o
/usr/src/k3b-24.08.2/src/k3btrm.cpp: In member function 'void K3b::TRM::start(const K3b::Msf&)':
/usr/src/k3b-24.08.2/src/k3btrm.cpp:45:27: error: 'useProxy' is not a member of 'KProtocolManager'
   45 |     if( KProtocolManager::useProxy() ) {
      |                           ^~~~~~~~
/usr/src/k3b-24.08.2/src/k3btrm.cpp:46:39: error: 'proxyFor' is not a member of 'KProtocolManager'
   46 |         QUrl proxy( KProtocolManager::proxyFor("http") );
      |                                       ^~~~~~~~
make[2]: *** [src/CMakeFiles/k3b.dir/build.make:2220: src/CMakeFiles/k3b.dir/k3btrm.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1594: src/CMakeFiles/k3b.dir/all] Error 2
make: *** [Makefile:136: all] Error 2


EXPECTED RESULT
a successful compile

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: 6.2.0
KDE Plasma Version: 6.2.0
KDE Frameworks Version: 6.7.0
Qt Version: 6.8.0

ADDITIONAL INFORMATION
- The following OPTIONAL packages have been found:

 * OpenGL
 * Qt6CoreTools (required version >= 6.8.0)
 * Qt6Core (required version >= 6.5.0)
 * Qt6WidgetsTools (required version >= 6.8.0)
 * XKB (required version >= 0.5.0), XKB API common to servers and clients., <http://xkbcommon.org>
 * Qt6GuiTools (required version >= 6.8.0)
 * Qt6Gui (required version >= 6.5.0)
 * Qt6WebEngineCoreTools (required version >= 6.8.0)
 * WrapVulkanHeaders
 * Qt6WebEngineWidgets, QtWebEngineWidgets is used for prettier k3bdiskinfoview.
 * Iconv
 * Qt6DBusTools (required version >= 6.8.0)
 * Qt6QmlTools (required version >= 6.8.0)
 * DvdRead, Libdvdread provides a simple foundation for reading DVD video disks., <https://www.videolan.org/developers/libdvdnav.html>
 * Taglib, Read and write tags in audio files, <https://taglib.org/>
 * MusicBrainz, Provide information about the CD, about the artist or about related information, <https://musicbrainz.org/>
 * PkgConfig
 * FFmpeg (required version >= 4.4.0), <https://ffmpeg.org/>
   Needed for the K3b FFmpeg decoder plugin which can decode virtually all audio types.
 * Flac, <https://xiph.org/flac/>
   Needed for the Flac audio decoder plugin.
 * Flac++, <https://xiph.org/flac/>
   Needed for the Flac audio decoder plugin.
 * Mad, <https://www.underbit.com/products/mad>
   Needed for the mp3 audio decoder plugin.
 * Muse, <https://www.musepack.net/>
   Needed for the Musepack audio decoder plugin
 * Sndfile, <http://www.mega-nerd.com/libsndfile>
   Needed for the libsndfile audio decoder plugin.
 * Lame, Lame mp3 encoder, <https://lame.sourceforge.io/>
   Needed for the lame mpf encoder encoder plugin.
 * OggVorbis, Ogg Vorbis, <https://xiph.org/vorbis/>
   Needed for the K3b Ogg Vorbis decoder and encoder plugins.

-- The following REQUIRED packages have been found:

 * ECM (required version >= 6.1)
 * Qt6 (required version >= 6.6)
 * KF6Archive (required version >= 6.1)
 * KF6Auth (required version >= 6.1)
 * KF6CoreAddons (required version >= 6.1)
 * KF6DocTools (required version >= 6.1)
 * KF6FileMetaData (required version >= 6.1)
 * Gettext
 * KF6I18n (required version >= 6.1)
 * KF6IconThemes (required version >= 6.1)
 * KF6KCMUtils (required version >= 6.1)
 * KF6JobWidgets (required version >= 6.7.0)
 * KF6KIO (required version >= 6.1)
 * KF6Notifications (required version >= 6.1)
 * KF6NewStuff (required version >= 6.1)
 * KF6NotifyConfig (required version >= 6.1)
 * KF6Solid (required version >= 6.1)
 * KF6WidgetsAddons (required version >= 6.1)
 * KF6XmlGui (required version >= 6.1)
 * KF6 (required version >= 6.1)
 * Samplerate, Audio sampling rate conversion., <http://www.mega-nerd.com/SRC>
 * Qt6DBus (required version >= 6.5.0)
 * KCddb6 (required version >= 5.1), Latest branch for CDDB library, <https://commits.kde.org/libkcddb>
   libkcddb is used to retrieve audio CD meta data from the internet.
 * SharedMimeInfo, A database of common MIME types, <https://freedesktop.org/wiki/Software/shared-mime-info/>
Comment 1 Albert Astals Cid 2024-10-13 17:50:21 UTC
Which distribution are you using that has a musicbrainz that old that k3b detects it?
Comment 2 Taurnil 2024-10-13 18:09:00 UTC
Linuar-Linux.

libmusicbrainz-5.1.0
Comment 3 Albert Astals Cid 2024-10-13 23:49:24 UTC
Git commit 4b538020210fff0f4611164ddb89c095e86f3025 by Albert Astals Cid.
Committed on 13/10/2024 at 23:45.
Pushed by aacid into branch 'master'.

Remove musicbrainz code

As the cmake find file says, this needs musicbrainz2 and the current
version is musicbrainz5. Having a quick look at the code we would need
to rewrite the code quite a bit, and it hasn't happened in almost a
decade, so clean the code for now

M  +0    -11   CMakeLists.txt
D  +0    -30   cmake/modules/FindMusicBrainz.cmake
M  +0    -2    config-k3b.h.cmake
M  +0    -15   src/CMakeLists.txt
D  +-    --    src/icons/actions/16-actions-musicbrainz.png
D  +-    --    src/icons/actions/64-actions-musicbrainz.png
M  +0    -2    src/icons/actions/CMakeLists.txt
D  +0    -89   src/k3bmusicbrainz.cpp
D  +0    -44   src/k3bmusicbrainz.h
D  +0    -83   src/k3btrm.cpp
D  +0    -51   src/k3btrm.h
D  +0    -120  src/projects/k3baudiotracktrmlookupdialog.cpp
D  +0    -58   src/projects/k3baudiotracktrmlookupdialog.h
M  +0    -4    src/projects/k3baudioview.cpp
M  +0    -65   src/projects/k3baudioviewimpl.cpp
M  +0    -4    src/projects/k3baudioviewimpl.h
D  +0    -147  src/projects/k3bmusicbrainzjob.cpp
D  +0    -63   src/projects/k3bmusicbrainzjob.h
D  +0    -117  src/projects/k3bmusicbrainztrackloopupjob.cpp
D  +0    -38   src/projects/k3bmusicbrainztrackloopupjob.h

https://invent.kde.org/multimedia/k3b/-/commit/4b538020210fff0f4611164ddb89c095e86f3025
Comment 4 Albert Astals Cid 2024-10-13 23:58:05 UTC
Git commit b48ad5640624b56b4766fc63360e2273d92580a8 by Albert Astals Cid.
Committed on 13/10/2024 at 23:57.
Pushed by aacid into branch 'release/24.08'.

Remove musicbrainz code

As the cmake find file says, this needs musicbrainz2 and the current
version is musicbrainz5. Having a quick look at the code we would need
to rewrite the code quite a bit, and it hasn't happened in almost a
decade, so clean the code for now
(cherry picked from commit 4b538020210fff0f4611164ddb89c095e86f3025)

M  +0    -11   CMakeLists.txt
D  +0    -30   cmake/modules/FindMusicBrainz.cmake
M  +0    -2    config-k3b.h.cmake
M  +0    -15   src/CMakeLists.txt
D  +-    --    src/icons/actions/16-actions-musicbrainz.png
D  +-    --    src/icons/actions/64-actions-musicbrainz.png
M  +0    -2    src/icons/actions/CMakeLists.txt
D  +0    -89   src/k3bmusicbrainz.cpp
D  +0    -44   src/k3bmusicbrainz.h
D  +0    -83   src/k3btrm.cpp
D  +0    -51   src/k3btrm.h
D  +0    -120  src/projects/k3baudiotracktrmlookupdialog.cpp
D  +0    -58   src/projects/k3baudiotracktrmlookupdialog.h
M  +0    -4    src/projects/k3baudioview.cpp
M  +0    -65   src/projects/k3baudioviewimpl.cpp
M  +0    -4    src/projects/k3baudioviewimpl.h
D  +0    -147  src/projects/k3bmusicbrainzjob.cpp
D  +0    -63   src/projects/k3bmusicbrainzjob.h
D  +0    -117  src/projects/k3bmusicbrainztrackloopupjob.cpp
D  +0    -38   src/projects/k3bmusicbrainztrackloopupjob.h

https://invent.kde.org/multimedia/k3b/-/commit/b48ad5640624b56b4766fc63360e2273d92580a8