Bug 494261 - [ProcessesView] Clicking on the already-selected item deselects it but the selection highlight doesn't go away
Summary: [ProcessesView] Clicking on the already-selected item deselects it but the se...
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: 6.1.5
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
: 494257 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-10-07 20:27 UTC by popov895
Modified: 2024-11-22 17:16 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description popov895 2024-10-07 20:27:48 UTC
SUMMARY

Clicking on the selected item in the Processes View disables the “End process” button. Same on Plasma 6.2.

STEPS TO REPRODUCE

1. Select any item in the Processes View: the "End Process" button becomes enabled
2. Click the selected item again: the "End Process" button becomes disabled

SOFTWARE/OS VERSIONS

Operating System: openSUSE Tumbleweed 20241006
KDE Plasma Version: 6.1.5
KDE Frameworks Version: 6.6.0
Qt Version: 6.7.3
Comment 1 popov895 2024-10-07 20:28:06 UTC
*** Bug 494257 has been marked as a duplicate of this bug. ***
Comment 2 Nate Graham 2024-11-13 19:29:08 UTC
Can reproduce.
Comment 3 Nate Graham 2024-11-13 22:23:04 UTC
Seems like the item actually gets deselected, but the selection highlight doesn't show it. So the behavior is correct (or at least, as intended) but the UI isn't accurate.
Comment 4 Nate Graham 2024-11-13 22:27:24 UTC
(in BaseCellDelegate.qml)
Comment 5 Bug Janitor Service 2024-11-21 11:22:56 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/315
Comment 6 Akseli Lahtinen 2024-11-22 10:01:21 UTC
Git commit b0c9c7b7a8c9becbc427ac4756016446f7ed6c88 by Akseli Lahtinen.
Committed on 22/11/2024 at 10:01.
Pushed by akselmo into branch 'master'.

BaseCellDelegate: Use correct colorSet when selected

When item is set selected, it will change its colorSet to Selection as
well, but it will not change back to normal on deselect. See https://invent.kde.org/frameworks/qqc2-desktop-style/-/blob/master/org.kde.desktop/TreeViewDelegate.qml?ref_type=heads#L41

This makes sure we use the correct colorset here.

M  +1    -1    src/table/BaseCellDelegate.qml

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/b0c9c7b7a8c9becbc427ac4756016446f7ed6c88
Comment 7 Akseli Lahtinen 2024-11-22 10:08:50 UTC
Git commit 13911268973ddde2304229a6565ce8429ff48ccd by Akseli Lahtinen.
Committed on 22/11/2024 at 10:06.
Pushed by akselmo into branch 'Plasma/6.2'.

BaseCellDelegate: Use correct colorSet when selected

When item is set selected, it will change its colorSet to Selection as
well, but it will not change back to normal on deselect. See https://invent.kde.org/frameworks/qqc2-desktop-style/-/blob/master/org.kde.desktop/TreeViewDelegate.qml?ref_type=heads#L41

This makes sure we use the correct colorset here.


(cherry picked from commit b0c9c7b7a8c9becbc427ac4756016446f7ed6c88)

a1441383 BaseCellDelegate: Use correct colorSet when selected

Co-authored-by: Akseli Lahtinen <akselmo@akselmo.dev>

M  +1    -1    src/table/BaseCellDelegate.qml

https://invent.kde.org/plasma/plasma-systemmonitor/-/commit/13911268973ddde2304229a6565ce8429ff48ccd