Bug 494218 - Remove FREEBSD_VERS from configure and build
Summary: Remove FREEBSD_VERS from configure and build
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (other bugs)
Version First Reported In: 3.24 GIT
Platform: Other FreeBSD
: NOR normal
Target Milestone: ---
Assignee: Paul Floyd
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-06 19:12 UTC by Paul Floyd
Modified: 2024-10-13 15:28 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Patch removing FREEBSD_VERS (67.55 KB, patch)
2024-10-06 19:14 UTC, Paul Floyd
Details
Update with helgrind lock leak detection turned off for 15.0 (69.73 KB, patch)
2024-10-13 11:42 UTC, Paul Floyd
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Floyd 2024-10-06 19:12:32 UTC
In order to at least not break Valgrind on every release of FreeBSD (since the configure script checks known versions via uname) I'd like to remove FREEBSD_VERS to put FreeBSD on the same footing as Linux and Solaris. Darwin still has versioning, no plans at the moment to change that.
Comment 1 Paul Floyd 2024-10-06 19:14:24 UTC
Created attachment 174490 [details]
Patch removing FREEBSD_VERS
Comment 2 Paul Floyd 2024-10-06 19:31:29 UTC
Pluses
- code is a bit simpler
- no need to keep updating for new versions

Minuses
- more effort for new syscalls
- no longer maintain old syscall names for older OSes (possibly a plus).

An example of the last point. SYS_mknodat 498 became SYS_freebsd11_mknodat 498 and SYS_mknodat 559. Previously 'mknodat' would have been used in error messages for syscall 498 on older OSes. Now only freebsd11_mknodat will be used for syscall 498.

If necessary I can switch to using the macro __FreeBSD_vers (a kind of patch-point number). It doesn't get incremented for every change to syscalls - I suspect that some additions that cause no backwards compatibility issues don't cause __FreeBSD_vers to be bumped.
Comment 3 Paul Floyd 2024-10-13 11:42:56 UTC
Created attachment 174767 [details]
Update with helgrind lock leak detection turned off for 15.0
Comment 4 Paul Floyd 2024-10-13 15:28:41 UTC
commit c87b75e8400f4b6efd77f014183d6180fa766686 (HEAD -> master, origin/master, origin/HEAD, bug494218)
Author: Paul Floyd <pjfloyd@wanadoo.fr>
Date:   Sun Oct 6 21:12:44 2024 +0200

    Bug 494218 - Remove FREEBSD_VERS from configure and build