Bug 494158 - File transfer storage fails (KDE Connect Android 1.32.5)
Summary: File transfer storage fails (KDE Connect Android 1.32.5)
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: android-application (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-05 08:03 UTC by mgruber_72
Modified: 2024-10-08 15:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mgruber_72 2024-10-05 08:03:59 UTC
SUMMARY

The Android app tells me that it was unable to store the transfered file.
I'm on Android 14 using KDE Connect 1.32.5.
The desktop client is 21.12.3-0ubuntu1 (Ubuntu Jammy)

STEPS TO REPRODUCE
1. Try to transfer a file from the desktop client to the Android client.

OBSERVED RESULT

Once the upload has finished, an Android notification appears that the file couldn't be stored.

EXPECTED RESULT

File should be stored, as it was the case before the ill-fated 1.32.4.
Comment 1 mgruber_72 2024-10-05 08:54:18 UTC
Seeming
Comment 2 mgruber_72 2024-10-05 08:54:42 UTC
The bug is most likely related to this change:
https://invent.kde.org/network/kdeconnect-android/-/commit/38e713f489d455c36893eac2e87454d0b15640a0
Comment 3 Luca Carlon 2024-10-05 10:25:43 UTC
How can you state that commit is related to the problem? Did you try to revert it?

Would it be possible for you to test this commit? https://invent.kde.org/lcarlon/kdeconnect-android/-/commit/f262bbc3e0f658d4d13a6168dbb681e85bef10e9

Please note that I'm not a kdeconnect developer, so it is possible that my patch breaks something else, it is only intended as a test.
Comment 4 mgruber_72 2024-10-05 10:41:34 UTC
(In reply to Luca Carlon from comment #3)
> How can you state that commit is related to the problem? Did you try to
> revert it?

I only scrolled through the commits and this was the most obvious one to me.

> Would it be possible for you to test this commit?
> https://invent.kde.org/lcarlon/kdeconnect-android/-/commit/
> f262bbc3e0f658d4d13a6168dbb681e85bef10e9

Unfortunately no - I could test APKs, but I'm unable to make builds.

FWIW I also tried to delete and re-add the device pairing, but that didn't make a difference.
Comment 5 Luca Carlon 2024-10-05 11:27:00 UTC
Apparently the KDE CI can help. In the artifacts there is the apk: https://invent.kde.org/lcarlon/kdeconnect-android/-/jobs/2172237. Would it be possible for you to test that?
Comment 6 mgruber_72 2024-10-05 12:11:59 UTC
I was just in the process of testing the APK (downloaded the archive to my Download folder), when I realised that the 1.32.5 transfers are actually stored. The only bug seems to be the notification, that it wasn't stored.

Odd and embarassing that I didn't notice this earlier.
Comment 7 Luca Carlon 2024-10-05 14:41:39 UTC
Can you confirm if the patch works for you? In that case I could submit the patch for review.
Comment 8 mgruber_72 2024-10-05 17:45:42 UTC
I tried to install it, but it the package installer says it conflicts with currently installed package (I do have unkown sources enabled and can install invidual APKs from F-Droid without any problems).
Comment 9 Luca Carlon 2024-10-05 17:46:58 UTC
Yes, you need to uninstall the official version for the test.
Comment 10 mgruber_72 2024-10-05 18:08:51 UTC
Success with the debug version after removing the Playstore version:
the error message is gone, instead it says successfully received (in my localized language) as it used to be.
You can submit the patch for review.

Sorry for the hassle with me: I am a alpha tester for an Android media player, where alpha APKs can be easily installed over the existing official Playstore version, hence my confusion.
Comment 11 Luca Carlon 2024-10-05 18:46:40 UTC
The debug package is not probably signed with the same key.
On the contrary, thank you for taking the time to help devs.
Comment 12 Albert Vaca Cintora 2024-10-08 15:48:26 UTC
Git commit 551b089d9ae4602df5d251bbe63ccb9de4146748 by Albert Vaca Cintora, on behalf of Luca Carlon.
Committed on 08/10/2024 at 15:48.
Pushed by albertvaka into branch 'master'.

Do not use FLAG_MUTABLE when targeting Android >= 34

M  +2    -2    src/org/kde/kdeconnect/Plugins/SharePlugin/ReceiveNotification.java

https://invent.kde.org/network/kdeconnect-android/-/commit/551b089d9ae4602df5d251bbe63ccb9de4146748