Bug 494079 - improve confusing menu item "Open transactions modified by this transaction..."
Summary: improve confusing menu item "Open transactions modified by this transaction..."
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (other bugs)
Version First Reported In: Trunk from git
Platform: unspecified All
: NOR normal
Target Milestone: 25.1.0
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-04 01:47 UTC by skierpage
Modified: 2024-10-04 19:41 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description skierpage 2024-10-04 01:47:44 UTC
SUMMARY
The History panel's context menu has "Open transactions modified by this transaction..." which is confusing

STEPS TO REPRODUCE
1. Choose View > Panels > History, then right-click on an item in its list.

OBSERVED RESULT
Confusing menu item.

EXPECTED RESULT
Change the menu item's text in plugins/skrooge/skrooge_operation/skgoperationplugin.cpp to not repeat the word "transaction".  I think "Open transactions modified by this action" is better terminology, and it matches the documentation for a similar command in the Skrooge Handbook in 3.1.4 The Go Menu:
    Open last modified…: Open transactions modified by the last action done

SOFTWARE/OS VERSIONS
all

ADDITIONAL INFORMATION

I filed bug 494077 to better document the ability to view modified transactions, so fix this before updating the documentation.

 The repeated "transaction"  happened as part of commit e330b9d303, the operation -> transaction terminology rename; the menu item used to be "Open operations modified by this transaction..."
Comment 1 skierpage 2024-10-04 01:53:59 UTC
(In reply to skierpage from comment #0)

> the documentation for a similar command in the Skrooge Handbook in 3.1.4 The Go Menu:
>     Open last modified…: Open transactions modified by the last action

By the way, I filed bug 490738 "ellipsis character in doc appears as … in PDF Skrooge handbook" and it was recently fixed in docs-kde-org , so this glitch should go away when https://docs.kde.org/trunk5/en/skrooge/skrooge/skrooge.pdf is next rebuilt.
Comment 2 Bug Janitor Service 2024-10-04 03:17:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/office/skrooge/-/merge_requests/51
Comment 3 skierpage 2024-10-04 19:41:20 UTC
Git commit 90a104663514ccbd10667f3e2c4f827f41d01fb8 by S Page.
Committed on 04/10/2024 at 03:10.
Pushed by smankowski into branch 'master'.

Improve confusing menu item text

Change "Open transactions modified by this transaction…" -> this action

M  +1    -1    plugins/skrooge/skrooge_operation/skgoperationplugin.cpp

https://invent.kde.org/office/skrooge/-/commit/90a104663514ccbd10667f3e2c4f827f41d01fb8