Bug 493994 - Unnecessary extra padding in Touchpad KCM
Summary: Unnecessary extra padding in Touchpad KCM
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_touchpad (show other bugs)
Version: 6.1.90
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-02 20:47 UTC by yellow.dog625
Modified: 2024-10-16 13:52 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.1
Sentry Crash Report:


Attachments
screenshot (221.01 KB, image/png)
2024-10-02 20:47 UTC, yellow.dog625
Details

Note You need to log in before you can comment on or make changes to this bug.
Description yellow.dog625 2024-10-02 20:47:01 UTC
Created attachment 174336 [details]
screenshot

SUMMARY

The top padding in the Touchpad KCM is excessively large compared to other KCMs in the KDE System Settings.
Comment 1 Nate Graham 2024-10-03 17:08:50 UTC
It's actually caused by the whole KCM having an invisible extra set of padding on all sides. You can see further evidence of this in the fast that the scrollbar is not centered in its track, and its separator line doesn't touch the top and bottom of the window.

Probably fixable, but I haven't figured out how yet.
Comment 2 Nate Graham 2024-10-03 17:12:56 UTC
Aha, found it. Patch incoming.
Comment 3 Bug Janitor Service 2024-10-03 17:17:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2569
Comment 4 yellow.dog625 2024-10-03 17:34:00 UTC
(In reply to Nate Graham from comment #2)
> Aha, found it. Patch incoming.

Thank you!
Comment 5 Nate Graham 2024-10-11 04:36:34 UTC
Git commit af302b741a12b33653162bc2700e866397c2ef12 by Nate Graham.
Committed on 11/10/2024 at 04:26.
Pushed by ngraham into branch 'master'.

kcms/touchpad: remove extra padding from QtWidgets wrapper layout

This KCM wraps the QML-provided content in a QtWidgets-provided box
layout. Those include 6px padding by default, but we don't want it here
since the QML code brings its own. Let's turn it off.
FIXED-IN: 6.2.1

M  +1    -0    kcms/touchpad/kcm.cpp

https://invent.kde.org/plasma/plasma-desktop/-/commit/af302b741a12b33653162bc2700e866397c2ef12
Comment 6 Nate Graham 2024-10-11 20:28:58 UTC
Git commit 554018d694075ae454c858d8fa139c1f2e24ab64 by Nate Graham.
Committed on 11/10/2024 at 20:28.
Pushed by ngraham into branch 'Plasma/6.2'.

kcms/touchpad: remove extra padding from QtWidgets wrapper layout

This KCM wraps the QML-provided content in a QtWidgets-provided box
layout. Those include 6px padding by default, but we don't want it here
since the QML code brings its own. Let's turn it off.
FIXED-IN: 6.2.1


(cherry picked from commit af302b741a12b33653162bc2700e866397c2ef12)

Co-authored-by: Nate Graham <nate@kde.org>

M  +1    -0    kcms/touchpad/kcm.cpp

https://invent.kde.org/plasma/plasma-desktop/-/commit/554018d694075ae454c858d8fa139c1f2e24ab64