Bug 493582 - Color Picker Layout jitters when using eye dropper
Summary: Color Picker Layout jitters when using eye dropper
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: * Unknown (show other bugs)
Version: 5.2.3
Platform: Flatpak Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-24 12:05 UTC by leogot
Modified: 2024-11-21 02:13 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Video recording of the Color Picker dialog while the bug is apparent (371.21 KB, video/mp4)
2024-09-24 12:05 UTC, leogot
Details
consitent jitter video (602.66 KB, video/x-matroska)
2024-11-15 01:35 UTC, Reinold Rojas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description leogot 2024-09-24 12:05:25 UTC
Created attachment 174025 [details]
Video recording of the Color Picker dialog while the bug is apparent

SUMMARY
When using the Eye-dropper from within the Color Picker dialog window, the entire layout of the dialog window jitters and breaks, as the mouse pointer moves and the text changes.

STEPS TO REPRODUCE
1. Open the Color Picker Window (e.g. pick foreground color)
2. Use the eye dropper button
3. move the pointer in large circles across the screen

OBSERVED RESULT
the layout jitters and components change size, as the TextLabel contents are updated.


EXPECTED RESULT
the layout remains constant while the text changes

SOFTWARE/OS VERSIONS
Pop!_OS 22.04 LTS

Krita 5.2.3
 Hidpi: true

Qt 5.15.7

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 6.8.0-76060800daily20240311-generic
  Pretty Productname: Freedesktop SDK 23.08 (Flatpak runtime)
  Product Type: org.freedesktop.platform
  Product Version: 23.08
  Desktop: pop:GNOME
  Appimage build: No

Locale

  Languages: de, de, de
  C locale: de_DE.UTF-8
  QLocale current: de
  QLocale system: de
  QTextCodec for locale: UTF-8
Comment 1 Reinold Rojas 2024-11-15 01:35:24 UTC
Created attachment 175832 [details]
consitent jitter video

I can confirm the jitter occurs on the Foreground color selector on Latest master and 5.2.6. I'm not quite sure why this jitter occurs as sometimes it happens when the sampling color doesn't even change values. Although I found a way to produce it a little more consistently.

Reproduce steps:
1. Open a new document
2. Pan down to ensure you can see past the edge of the image (so there is some "greyspace" on the bottom of the canvas)
3. Click on "Foreground color Selector"
4. Click on eye dropper
5. Mouse over between the edge of the canvas and the scroll bar

Added a video showing the jitter. If you try and watch it frame by frame you can see sometimes it occurs even when the values don't change.
Comment 2 Emmet O'Neill 2024-11-21 02:13:27 UTC
Git commit 14953c925c0b916218e3162a175d81b18ebda95a by Emmet O'Neill.
Committed on 21/11/2024 at 02:11.
Pushed by emmetoneill into branch 'master'.

Fix/UI: Stop color selector widget from expanding while sampling.

I *believe* that this should fix the janky UI,
though I had a hard time consistently reproducing the issue on my system.
Feel free to reopen this bug if the issue still persists in the nightly builds.

M  +2    -2    libs/widgets/WdgDlgInternalColorSelector.ui

https://invent.kde.org/graphics/krita/-/commit/14953c925c0b916218e3162a175d81b18ebda95a