Bug 493453 - Pick labels partially block the filename in the main view when thumbnails are certain sizes
Summary: Pick labels partially block the filename in the main view when thumbnails are...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-MainView (show other bugs)
Version: 8.4.0
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-21 20:14 UTC by amdfanboi@gmail.com
Modified: 2024-09-22 05:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.5.0
Sentry Crash Report:


Attachments
webm video that shows how the pick labels change size and position partially blocking the filename (3.25 MB, video/webm)
2024-09-21 20:14 UTC, amdfanboi@gmail.com
Details
Expected: normal sized flags in 8.3.0 (598.31 KB, image/jpeg)
2024-09-22 02:30 UTC, amdfanboi@gmail.com
Details
Enlarged flag in version 8.5.0 (648.25 KB, image/jpeg)
2024-09-22 02:31 UTC, amdfanboi@gmail.com
Details

Note You need to log in before you can comment on or make changes to this bug.
Description amdfanboi@gmail.com 2024-09-21 20:14:15 UTC
Created attachment 173942 [details]
webm video that shows how the pick labels change size and position partially blocking the filename

SUMMARY
Images in Digikam that have pick labels (red, green, and yellow flags) have the flags changing sizes in the main window as the thumbnail size slider gets changed.  This results in the flags sometimes being larger than appropriate and blocking part of the filename of the thumbnail (see attached)

STEPS TO REPRODUCE
1. Assign a pick label to an image
2. Change thumbnail size using the slider in the bottom right corner of the main window

OBSERVED RESULT
Flags are covering part of the filename text of thumbnails when the filename is long enough and the thumbnail size is of an in-between size.

EXPECTED RESULT
In 8.3 and previous versions the flag is a fixed size.  Its position might change in the thumbnail tile as you change the thumbnail size slider but it never occupied the same space as the filename.

SOFTWARE/OS VERSIONS
Windows: Windows 10
Qt Version: 6
Comment 1 Maik Qualmann 2024-09-21 21:14:38 UTC
I have now tested it in Linux and Windows, the "pole" of the flag has always slipped over the font, but never the whole flag.
The problem has probably been fixed with bug 490866.
Please test the pre-release digikam-8.5.0 from here:

https://files.kde.org/digikam/

Maik
Comment 2 amdfanboi@gmail.com 2024-09-22 02:30:45 UTC
Created attachment 173949 [details]
Expected: normal sized flags in 8.3.0
Comment 3 amdfanboi@gmail.com 2024-09-22 02:31:23 UTC
Created attachment 173950 [details]
Enlarged flag in version 8.5.0
Comment 4 amdfanboi@gmail.com 2024-09-22 02:37:51 UTC
(In reply to Maik Qualmann from comment #1)
> I have now tested it in Linux and Windows, the "pole" of the flag has always
> slipped over the font, but never the whole flag.
> The problem has probably been fixed with bug 490866.
> Please test the pre-release digikam-8.5.0 from here:
> 
> https://files.kde.org/digikam/
> 
> Maik

I can see what you mean about the flag pole slipping over the font in previous versions.  The flag enlarging in 8.4.0 also occurs in 8.5.0 on my windows 10 machine.  It makes the filename harder to read than in 8.3.0.  I've added screenshots of the same album at the same thumbnail tile size for 8.3.0 and 8.5.0 to illustrate what I'm seeing.
Comment 5 Maik Qualmann 2024-09-22 05:22:03 UTC
The fact that the flag has not been enlarged is more of a bug in digiKam-8.3.0, in Linux it has always been like this. The flag should scale when the thumbnails get bigger. Unfortunately we don't have any more space, with a 1:1 aspect ratio thumbnail the tip of the flag is already at the thumbnail. OK, we will scale it a little less, but we will have to live with a small compromise.

Maik
Comment 6 Maik Qualmann 2024-09-22 05:57:52 UTC
Git commit 74c27f79d9942c58c4578a37a5a1c3b3c8cec3ed by Maik Qualmann.
Committed on 22/09/2024 at 05:56.
Pushed by mqualmann into branch 'master'.

limit the maximum size of the pick label in thumbnails
FIXED-IN: 8.5.0

M  +1    -1    NEWS
M  +4    -3    core/app/items/delegate/digikamitemdelegate.cpp
M  +16   -9    core/utilities/import/items/importdelegate.cpp

https://invent.kde.org/graphics/digikam/-/commit/74c27f79d9942c58c4578a37a5a1c3b3c8cec3ed