Bug 493112 - Unchecking "Search results include filtered windows" breaks layout
Summary: Unchecking "Search results include filtered windows" breaks layout
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-overview (show other bugs)
Version: 6.1.90
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: regression
: 493917 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-09-14 11:36 UTC by Dashon
Modified: 2024-10-01 15:08 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.0
Sentry Crash Report:


Attachments
Window filtering not properly being disabled (347.72 KB, image/png)
2024-09-14 11:36 UTC, Dashon
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dashon 2024-09-14 11:36:32 UTC
Created attachment 173653 [details]
Window filtering not properly being disabled

SUMMARY
The ability to disable window filtering in the search results seems to have become broken in plasma 6.2. Window filtering is instead always enabled, but the window will be overlayed on top of the search results.

STEPS TO REPRODUCE
1. Go to Desktop Effects -> Overview -> Search results include filtered windows.
2. Uncheck the box.
3. Open some window such as firefox or konsole.
4. search for the name of that window.

OBSERVED RESULT
The window should not show up since the user has asked that those results explicitly not be displayed.

EXPECTED RESULT
Only the krunner search results should be displayed.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20240912
KDE Plasma Version: 6.1.90
KDE Frameworks Version: 6.7.0
Qt Version: 6.7.2
Kernel Version: 6.10.9-1-default (64-bit)
Graphics Platform: Wayland
Processors: 4 × Intel® Core™ i3-7100U CPU @ 2.40GHz
Memory: 7.6 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 620
Manufacturer: Dell Inc.
Product Name: Inspiron 15-3567
Comment 1 cwo 2024-09-14 22:20:07 UTC
Can reproduce.

The window previews are still being displayed and overlap the krunner search results, making them unreadable. They can't be focused with the arrow keys like when filtered windows are enabled (or when no search term is entered), so it behaves correctly but displays the filtered windows anyway.
Comment 2 Bug Janitor Service 2024-09-19 13:51:28 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/6425
Comment 3 Akseli Lahtinen 2024-09-19 16:56:53 UTC
Git commit a8deb69230a33f0fb7d7b101444034c9475451aa by Akseli Lahtinen.
Committed on 19/09/2024 at 16:15.
Pushed by akselmo into branch 'master'.

overview/main.qml: Hide WindowHeap when searching if filterWindows setting is toggled off

If the "Search results include filtered windows" is off, only show
WindowHeap if there is no search text inputted.
FIXED-IN: 6.2.0

M  +1    -0    src/plugins/overview/qml/main.qml

https://invent.kde.org/plasma/kwin/-/commit/a8deb69230a33f0fb7d7b101444034c9475451aa
Comment 4 Akseli Lahtinen 2024-09-19 17:41:29 UTC
Git commit c9fd243c8f97ef8c833d71daaa834833b54c5aa7 by Akseli Lahtinen.
Committed on 19/09/2024 at 16:57.
Pushed by akselmo into branch 'Plasma/6.2'.

overview/main.qml: Hide WindowHeap when searching if filterWindows setting is toggled off

If the "Search results include filtered windows" is off, only show
WindowHeap if there is no search text inputted.
FIXED-IN: 6.2.0


(cherry picked from commit a8deb69230a33f0fb7d7b101444034c9475451aa)

a8deb692 overview/main.qml: Hide WindowHeap when searching if filterWindows setting is toggled off

Co-authored-by: Akseli Lahtinen <akselmo@akselmo.dev>

M  +1    -0    src/plugins/overview/qml/main.qml

https://invent.kde.org/plasma/kwin/-/commit/c9fd243c8f97ef8c833d71daaa834833b54c5aa7
Comment 5 Nate Graham 2024-10-01 15:08:48 UTC
*** Bug 493917 has been marked as a duplicate of this bug. ***