Bug 493057 - Inappropriate host name capitalization
Summary: Inappropriate host name capitalization
Status: REPORTED
Alias: None
Product: Smb4k
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Alexander Reinholdt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-13 12:34 UTC by Pedro V
Modified: 2024-09-13 12:34 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro V 2024-09-13 12:34:54 UTC
The user-provided host name is converted to uppercase unconditionally almost everywhere, which is inappropriate for the following reasons:
- It's usual to capitalize the NetBIOS name, but it doesn't seem to be mandatory. Searching for pictures of Windows mounted shares revealed plenty of examples of lowercase names, especially in cases of DNS names being used.
- The user provided URL is allowed to contain an arbitrary host name which is preserved in a case sensitive manner in the bookmark file, which results in an odd combination of allowing custom names, but forcing an outdated tradition on the names.

Considering this a bug instead of a wishlist item due to non-ancient Windows versions seemingly not forcing uppercase names (anymore?).

Beware of potential breakage. If this ever gets dealt with, a new config entry (per mount?) should determine if the name is case sensitive ("new"), or should be still capitalized ("old") to make sure old bookmarked items still get the same path.

This may be also somewhat obsoleted if the current prefix-based path approach gets replaced by something more flexible in the future, like a path pattern with variables, or custom paths per mounts. Names in the GUI still shouldn't be unconditionally capitalized though.