Bug 492950 - SDDM theme previews in SDDM KCM are all blurry
Summary: SDDM theme previews in SDDM KCM are all blurry
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_sddm (show other bugs)
Version: master
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-10 15:29 UTC by Justin Zobel
Modified: 2024-09-11 10:07 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/sddm-kcm/-/commit/b7a85a643c8bb8f76ab1b1276217943e8887ce03
Version Fixed In: 6.2.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Zobel 2024-09-10 15:29:11 UTC 
STEPS TO REPRODUCE
1. Open SDDM KCM
2. Click Breeze theme
3. Click i to to preview theme

OBSERVED RESULT
Blurry

EXPECTED RESULT
Crisp

All built from git master on Sept 10
Comment 1 Nate Graham 2024-09-11 09:27:08 UTC 
It is blurry indeed. And it affects all theme previews, so it's not an issue with the artwork.
Comment 2 Nate Graham 2024-09-11 09:39:01 UTC 
Git commit b7a85a643c8bb8f76ab1b1276217943e8887ce03 by Nate Graham.
Committed on 11/09/2024 at 09:38.
Pushed by ngraham into branch 'master'.

Don't unnecessarily set sourceSize on preview image

It isn't needed and makes the image blurry.
FIXED-IN: 6.2.0

M  +0    -1    src/ui/DetailsDialog.qml

https://invent.kde.org/plasma/sddm-kcm/-/commit/b7a85a643c8bb8f76ab1b1276217943e8887ce03
Comment 3 Nate Graham 2024-09-11 10:07:29 UTC 
Git commit 3eef21bd6dda219e58ccc005bd051810f786ea77 by Nate Graham.
Committed on 11/09/2024 at 10:07.
Pushed by ngraham into branch 'master'.

Put the preview image in a card

Looks nicer and more consistent with other image-in-card UIs, and lets
us get rid of the layer effect which was contributing a small amount of
residual blurriness. It's a net code removal too.

M  +11   -15   src/ui/DetailsDialog.qml

https://invent.kde.org/plasma/sddm-kcm/-/commit/3eef21bd6dda219e58ccc005bd051810f786ea77