Bug 492932 - Notifications with long URLs that wrap anyway unnecessarily expand in width
Summary: Notifications with long URLs that wrap anyway unnecessarily expand in width
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (other bugs)
Version First Reported In: master
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-09-10 07:52 UTC by Nate Graham
Modified: 2024-09-20 07:39 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Wide boi popup (362.23 KB, image/png)
2024-09-10 07:52 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-09-10 07:52:03 UTC
Created attachment 173518 [details]
Wide boi popup

See screenshot. Regression from https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4598.
Comment 2 Marco Martin 2024-09-16 12:41:49 UTC
I think the two related 492932 and https://bugs.kde.org/show_bug.cgi?id=492861 
are from some qtquick layout quirks caused by https://bugreports.qt.io/browse/QTBUG-126196
 that would force to set both the title and the main body of the notification to an hardcoded maximum width for the time being
Comment 3 Marco Martin 2024-09-16 13:29:03 UTC
also this is exactly what https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4598 was set to do.

it made popups stretchable to wider sizes, but we don't have fine grained control on text hints like "if that'a an url, you can elide it" so either it can become very wide, or it can't
Comment 4 Bug Janitor Service 2024-09-16 13:30:11 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4705
Comment 5 Marco Martin 2024-09-19 14:44:07 UTC
Git commit e144c6e96e8e8b1ef4049f80a87e445ab8570b0d by Marco Martin.
Committed on 19/09/2024 at 14:44.
Pushed by mart into branch 'master'.

Limit maximum popup width and stretch body label

Add a maximum, kinda hardcoded popup maximum width to not
make notifications so exceedingly large, keep headings
expanding, while still wrapping
Related: bug 492861

M  +3    -2    applets/notifications/package/contents/ui/NotificationItem.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/e144c6e96e8e8b1ef4049f80a87e445ab8570b0d
Comment 6 Marco Martin 2024-09-20 07:39:14 UTC
Git commit e7ea4203bafa9e057a50b54386f9604324d6ff55 by Marco Martin.
Committed on 20/09/2024 at 07:16.
Pushed by mart into branch 'Plasma/6.2'.

Limit maximum popup width and stretch body label

Add a maximum, kinda hardcoded popup maximum width to not
make notifications so exceedingly large, keep headings
expanding, while still wrapping
Related: bug 492861


(cherry picked from commit e144c6e96e8e8b1ef4049f80a87e445ab8570b0d)

7368b6f9 Limit maximum popup width and stretch body label
d3813bdf different attempt

Co-authored-by: Marco Martin <notmart@gmail.com>

M  +3    -2    applets/notifications/package/contents/ui/NotificationItem.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/e7ea4203bafa9e057a50b54386f9604324d6ff55