Bug 492842 - fd6c2bf2ad7c022a464c0799ea0256fb692d6618 subtly breaks return/enter key handling for launching apps
Summary: fd6c2bf2ad7c022a464c0799ea0256fb692d6618 subtly breaks return/enter key handl...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: master
Platform: Other Linux
: VHI normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-09-08 21:00 UTC by Nate Graham
Modified: 2024-09-09 18:28 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-09-08 21:00:47 UTC
That commit fixed Bug 479233. However with it present, I observe the following effects:

1. When I add Icon Explorer, Dolphin, or any other multi-instance-capable app to the Favorites grid and activate it with the keyboard's Enter key, two instances open, not one.
2. When I search for "skanpage", there is one search result for the Skanpage app, but pressing the Enter/Return key does not launch it.

Reverting fd6c2bf2ad7c022a464c0799ea0256fb692d6618 resolves both issues.
Comment 1 Bug Janitor Service 2024-09-09 05:42:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2508
Comment 2 David Edmundson 2024-09-09 18:28:39 UTC
Git commit 39637e03050afd596320fc5681d8821b5dfe79f9 by David Edmundson.
Committed on 09/09/2024 at 18:19.
Pushed by davidedmundson into branch 'master'.

applets/kickoff: Accept key event after handling action triggering

If the listview consumes the key event, no-one else should also perform
an action. This is important as some questionable key forwarding logic
in Kickoff can apparently end up with keys processed by the ListView
twice if they're not consumed.

M  +1    -0    applets/kickoff/package/contents/ui/KickoffGridView.qml
M  +1    -0    applets/kickoff/package/contents/ui/KickoffListView.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/39637e03050afd596320fc5681d8821b5dfe79f9