Bug 492784 - Changing keyboard shortcut scheme deletes 'Assign Tag' keyboard shortcuts
Summary: Changing keyboard shortcut scheme deletes 'Assign Tag' keyboard shortcuts
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Keyboard (show other bugs)
Version: 8.4.0
Platform: Manjaro Linux
: NOR minor
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-08 02:54 UTC by Rebecca Riley
Modified: 2024-09-10 19:27 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.5.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rebecca Riley 2024-09-08 02:54:56 UTC
If you have 'Assign Tag "xxx"' shortcuts assigned in a keyboard scheme, changing to another scheme will delete those shortcuts.  Other shortcuts remain unchanged.

To reproduce:
1. Assign a tag shortcut in the Tag Manager.  Tag shortcuts cannot be initially assigned from the 'Configure Keyboard Shortcuts' dialogue.
2. In 'Configure Keyboard Shortcuts,' change to another scheme (Manage Schemes > Current scheme).
3. Go back to the original scheme.
4. 'Assign Tag' shortcuts will be unassigned.
Comment 1 Maik Qualmann 2024-09-08 07:34:21 UTC
After playing around with it a bit and trying to save the key shortcuts, I think it's a bug in the Key Shortcut Editor. The Key Shortcut Editor is part of KDE though.
It is possible to export a key shortcut scheme. At the moment I would recommend doing this to save the created tag shortcuts.

Maik
Comment 2 Rebecca Riley 2024-09-08 08:37:24 UTC
(In reply to Maik Qualmann from comment #1)
> After playing around with it a bit and trying to save the key shortcuts, I
> think it's a bug in the Key Shortcut Editor. The Key Shortcut Editor is part
> of KDE though.
> It is possible to export a key shortcut scheme. At the moment I would
> recommend doing this to save the created tag shortcuts.
> 
> Maik

Thanks for the quick reply.  Fortunately this isn't really a problem for me (and probably most people) since I don't change shortcut schemes, but I thought I would report it since some do.  I found this bug while trying to resolve a bunch of 'key sequence is ambiguous' conflicts with my shortcuts.  As an aside, what fixed that was clearing all the keyboard shortcuts in the Default scheme.  You can't delete the Default scheme.  Well, you can, but it will resurrect every time you restart digiKam.
Comment 3 Maik Qualmann 2024-09-08 20:00:06 UTC
I have tested a few more. We save the tag key shortcuts in the digiKam database. So if the schema is reset, the tag key shortcuts in the database are also deleted. This also makes it possible to change the tag key shortcuts via the editor. I actually don't see any errors here. So if you have made extensive schema changes, you should create a backup using the export function.

Maik
Comment 4 Rebecca Riley 2024-09-09 04:30:31 UTC
Even if not technically an error, I would still say that this is unexpected behavior since (1) other shortcuts persist after changing schemes and (2) the ability to change schemes with no warning about shortcut deletions implies that changing schemes is a non-destructive action.  Of course, it is always helpful to have backups :)  but ideally things being deleted shouldn't occur without some warning or indication.

For reference, could you note any other shortcuts, settings, etc. this is the case for?  (Database deletion upon switching schema, that is.)  Thanks!
Comment 5 Maik Qualmann 2024-09-10 06:42:51 UTC
Git commit 5af7c42b01b1ab915a9e8c5310e2643a9e73c8ad by Maik Qualmann.
Committed on 10/09/2024 at 06:41.
Pushed by mqualmann into branch 'master'.

store tag key shortcuts in the KXmlGui config file
FIXED-IN: 8.5.0

M  +1    -1    NEWS
M  +5    -4    core/libs/tags/engine/tagsactionmngr.cpp

https://invent.kde.org/graphics/digikam/-/commit/5af7c42b01b1ab915a9e8c5310e2643a9e73c8ad
Comment 6 Rebecca Riley 2024-09-10 19:27:34 UTC
Thanks Maik!