Bug 492274 - Improve Clip Speed applet
Summary: Improve Clip Speed applet
Status: CONFIRMED
Alias: None
Product: kdenlive
Classification: Applications
Component: Timeline & Editing (show other bugs)
Version: 22.04.3
Platform: Ubuntu Linux
: NOR wishlist
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2024-08-27 15:09 UTC by Uwe Dippel
Modified: 2024-10-26 13:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
105,47 percent speeds up too fast (track line 3) (37.99 KB, image/png)
2024-08-27 15:09 UTC, Uwe Dippel
Details
105,46 percent speed up insufficiently (track line 3) (34.38 KB, image/png)
2024-08-27 15:12 UTC, Uwe Dippel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Uwe Dippel 2024-08-27 15:09:57 UTC
Created attachment 173005 [details]
105,47 percent speeds up too fast (track line 3)

SUMMARY
Changing the clip speed usually doesn't lead to lip-synchronous behaviour. This is because of the limitation of speed ratio.

STEPS TO REPRODUCE
1. Load a longer clip into the time line
2. Load another clip into the time line, with a different speed
3. Try to adjust the speed of either to the other clip

OBSERVED RESULT
It is impossible to run both in parallel

EXPECTED RESULT
A setting without artificial limitations of the speed ratio

ADDITIONAL INFORMATION
The 'Clip Speed' applet allows setting of ratios in percentages, with 2 digits after the decimal point. Only at first sight is this 'generous'. With a longer clip, eg of 200000 frames, this isn't more than a precision of 20 frames (!!, one second). 

The consequences are visible in the attached screen shots. The to-be-adjusted clip is either too fast or too slow, due to the setting to a 1/100 of a percentage.
There is no reason, instead of this somewhat artificial setting, to allow setting a ratio. Preferably by reading the number of frames of both clips, diving these two numbers, and entering this ratio instead.
Comment 1 Uwe Dippel 2024-08-27 15:12:29 UTC
Created attachment 173006 [details]
105,46 percent speed up insufficiently (track line 3)

Both attachments show that the synchronous ratio lies somewhere between 105,46 percent and 105,47 percent. 
Once a purely mathematical ratio can be entered, both clips can have the same lengths.
Comment 2 Uwe Dippel 2024-08-27 15:14:36 UTC
Comment on attachment 173006 [details]
105,46 percent speed up insufficiently (track line 3)

(Sorry, just confounded the two screenshots; easily visible when looking at the percentages)
Comment 3 Uwe Dippel 2024-08-27 15:14:36 UTC
Comment on attachment 173006 [details]
105,46 percent speed up insufficiently (track line 3)

(Sorry, just confounded the two screenshots; easily visible when looking at the percentages)
Comment 4 Uwe Dippel 2024-08-29 09:16:49 UTC
Thanks for accepting this. The same applies to the "Time Remap" applet, by the way. 
And yet one more thing: I would be favourable, if one could select time or frames in these applets. For some use cases, we know how long the clip should play (time), or how many frames it should contain; like here in lip-synchronous applications. 
As of now, I'd have to select time or frames for the project overall, but cannot leave the time line at time, and set these applets to frames; with a pull-down like one can do in the time line. 
Totally perfect would be applets, where with changes of whatever value (percentage, time, frames) the other two values are synchronously re-calculated and displayed.
Comment 5 Uwe Dippel 2024-08-29 09:17:57 UTC
Thanks for accepting this. The same applies to the "Time Remap" applet, by the way. 
And yet one more thing: it would be favourable, if one could select time or frames in these applets. For some use cases, we know how long the clip should play (time), or how many frames it should contain; like here in lip-synchronous applications. 
As of now, I'd have to select time or frames for the project overall, but cannot leave the time line at time, and set these applets to frames; with a pull-down like one can do in the time line. 
Totally perfect would be applets, where with changes of whatever value (percentage, time, frames) the other two values are synchronously re-calculated and displayed.
Comment 6 Jean-Baptiste Mardelle 2024-08-31 13:16:22 UTC
Git commit bf2b3d6c86397ed12ce2db468b6c64c5e4a3673a by Jean-Baptiste Mardelle.
Committed on 31/08/2024 at 13:15.
Pushed by mardelle into branch 'master'.

Use custom spin box allowing arbitrary digits for speed dialog.

M  +1    -1    src/definitions.h
M  +17   -17   src/timeline2/view/dialogs/speeddialog.cpp
M  +1    -0    src/timeline2/view/dialogs/speeddialog.h
M  +2    -2    src/titler/graphicsscenerectmove.cpp
M  +2    -3    src/titler/graphicsscenerectmove.h
M  +52   -51   src/titler/titlewidget.cpp
M  +3    -3    src/titler/titlewidget.h
M  +19   -21   src/ui/clipspeed_ui.ui
M  +8    -0    src/widgets/CMakeLists.txt
A  +113  -0    src/widgets/precisionspinbox.cpp     [License: GPL(3+eV) GPL(v3.0)]
A  +59   -0    src/widgets/precisionspinbox.h     [License: GPL(3+eV) GPL(v3.0)]

https://invent.kde.org/multimedia/kdenlive/-/commit/bf2b3d6c86397ed12ce2db468b6c64c5e4a3673a
Comment 7 Jean-Baptiste Mardelle 2024-09-01 13:13:49 UTC
Git commit 83738817177c12e250315042c347d6989d025ba2 by Jean-Baptiste Mardelle.
Committed on 01/09/2024 at 13:13.
Pushed by mardelle into branch 'master'.

Switch time remap to the new precision spin box allowing 6 decimals instead of previous 2

M  +6    -2    src/dialogs/timeremap.cpp
M  +49   -67   src/ui/timeremap_ui.ui

https://invent.kde.org/multimedia/kdenlive/-/commit/83738817177c12e250315042c347d6989d025ba2
Comment 8 emohr 2024-10-26 10:08:53 UTC
@Uwe. Please try with the Master build if it's implemented. https://cdn.kde.org/ci-builds/multimedia/kdenlive/master/linux/