Bug 492054 - Default button to NO in confirmation box
Summary: Default button to NO in confirmation box
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Albums-Trash (show other bugs)
Version: 8.5.0
Platform: Other Other
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-22 23:32 UTC by Jérôme DEMEULLE
Modified: 2024-10-03 18:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.5.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jérôme DEMEULLE 2024-08-22 23:32:26 UTC
This is a whish :
Is that possible to have the NO button selected by  defaukt in confirmation box when empty the trash or Shift-Del a photograp ?
Comment 1 caulier.gilles 2024-08-23 02:56:11 UTC
Default trash button is already "No" in dialogs.
Comment 2 caulier.gilles 2024-08-23 03:02:10 UTC
Git commit 7a0184952e061f71b241c1b09fe99f3dbb826779 by Gilles Caulier.
Committed on 23/08/2024 at 03:01.
Pushed by cgilles into branch 'master'.

set default button to Cancel in delete dialog
FIXED-IN: 8.5.0

M  +1    -1    core/libs/dialogs/deletedialog.cpp

https://invent.kde.org/graphics/digikam/-/commit/7a0184952e061f71b241c1b09fe99f3dbb826779
Comment 3 Jérôme DEMEULLE 2024-08-23 16:18:35 UTC
(In reply to caulier.gilles from comment #1)
> Default trash button is already "No" in dialogs.

Strange, not for me (right click on Trash to empty it or even on items in view of trash).
Would be that linked to KDE framework ?
Comment 4 caulier.gilles 2024-08-23 18:39:39 UTC
Yes it is. Just tested with last 8.5.0 pre-release under MacOS.
Comment 5 caulier.gilles 2024-08-23 18:40:01 UTC
And this dialog do not come from KDE framework.
Comment 6 Maik Qualmann 2024-10-03 18:53:49 UTC
Git commit 168ca05be0cc703b9d54354fbf1bca2ff0bf8985 by Maik Qualmann.
Committed on 03/10/2024 at 18:52.
Pushed by mqualmann into branch 'master'.

make the default key dependent on the delete action
It's really annoying if the trash button isn't the
default when deleting to the trash.
For complete deletion without the trash,
Cancel is the correct default.

M  +3    -1    core/libs/dialogs/deletedialog.cpp

https://invent.kde.org/graphics/digikam/-/commit/168ca05be0cc703b9d54354fbf1bca2ff0bf8985