Bug 491981 - Have the pause button in a copy notification change based on its state
Summary: Have the pause button in a copy notification change based on its state
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 6.1.4
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2024-08-21 10:57 UTC by Antti Savolainen
Modified: 2024-09-22 21:35 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.3.0
Sentry Crash Report:


Attachments
Demonstrative video (53.59 KB, video/webm)
2024-08-21 10:57 UTC, Antti Savolainen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Savolainen 2024-08-21 10:57:17 UTC
Created attachment 172807 [details]
Demonstrative video

SUMMARY
In my opinion on a glance value the highlight doesn't provide enough information on what a click on the button would do. This should be changed so that when active, the button should change to read "▶ Continue".

STEPS TO REPRODUCE
1. Start a copy
2. Pause the copy for the desktop notification

OBSERVED RESULT
The text on the button stays the same.

EXPECTED RESULT
The text should change to reflect what pressing the button again would do.

SOFTWARE/OS VERSIONS
Linux: Arch Linux
KDE Plasma Version: 6.1.4
KDE Frameworks Version: 6.5.0
Qt Version: 6.7.2
Comment 1 Nate Graham 2024-08-21 14:44:52 UTC
Agreed. This shouldn't be a toggle button, but rather two pushbuttons with different icons and text.
Comment 2 Bug Janitor Service 2024-08-23 02:31:28 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4635
Comment 3 Nate Graham 2024-09-20 15:59:48 UTC
Git commit 09ccca3bed4099a52ba332261e782f5b4e3d549a by Nate Graham.
Committed on 20/09/2024 at 15:59.
Pushed by ngraham into branch 'master'.

applets/notifications: make pause/resume button not checkable

It's clearer when the button changes its icon and text based on the
context, rather than being checkable and having static icons and text.
FIXED-IN: 6.3.0

M  +8    -17   applets/notifications/package/contents/ui/JobItem.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/09ccca3bed4099a52ba332261e782f5b4e3d549a