Bug 491848 - [regression] Activity Manager and Activities widget do not show custom icons
Summary: [regression] Activity Manager and Activities widget do not show custom icons
Status: RESOLVED FIXED
Alias: None
Product: kactivitymanagerd
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Ivan Čukić
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-18 08:23 UTC by Oded Arbel
Modified: 2024-08-22 22:38 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot showing the problem (214.60 KB, image/png)
2024-08-18 08:23 UTC, Oded Arbel
Details
Same problem - possibly - in application launcher (82.41 KB, image/png)
2024-08-19 13:59 UTC, Oded Arbel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oded Arbel 2024-08-18 08:23:20 UTC
Created attachment 172722 [details]
screenshot showing the problem

Since updating to Neon unstable (6.2 dev), activities whose icons are custom images (instead of selected from the system icons) no longer show their icons in the Activities panel widget, or the Activity Manager side bar.

See attached screenshot.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 6.1.80
KDE Frameworks Version: 6.6.0
Qt Version: 6.7.2
Kernel Version: 6.8.0-40-generic (64-bit)
Graphics Platform: Wayland
Processors: 20 × 12th Gen Intel® Core™ i7-12700H
Memory: 31.0 GiB of RAM
Graphics Processor: Mesa Intel® Graphics
Comment 1 Oded Arbel 2024-08-19 13:59:11 UTC
Created attachment 172752 [details]
Same problem - possibly - in application launcher

I think its the same problem I see in the application launcher (screenshot attached) - some launchers that were working fine in 6.1 are now showing "blank page" icons. All these launchers have their `Icon` field set to an absolute path to a user owned icon. Other launchers either use a logical name, or an absolute path to a system icon (under /usr/share/pixmaps).
Comment 2 Jesse Litton 2024-08-21 12:28:33 UTC
Can confirm.  After building from latest source about a week back (and every recompile since), I lost my custom application launcher icon.  I tested with setting it to other file types, but SVGs, PNGs, etc. all display the blank page icon.

Also, the system tray icons for the following apps are all displaying blank pages too:

- BetterBird
- SpiderOakONE
- Microsoft Teams-Insiders (old electron wrapped app version)
Comment 3 Jesse Litton 2024-08-21 12:32:07 UTC
Oh, and as Oded points out:  I too see the same thing within the application launcher.  All my apps with .desktop files pointing to custom icons show as blank pages.
Comment 4 Oded Arbel 2024-08-21 12:58:25 UTC
(In reply to Jesse Litton from comment #2)
> Also, the system tray icons for the following apps are all displaying blank
> pages too:

I have a similar behavior with the system tray icon for the variety wallpaper changer, which I wasn't sure if it is related - the system tray icon is supposed to be a thumbnail of the current wallpaper image, but now - instead - it starts as the generic image icon and when the wallpaper changes (which would prompt an icon change), the icon becomes a blank page icon.
Comment 5 Jesse Litton 2024-08-21 14:39:45 UTC
(In reply to Oded Arbel from comment #4)
> (In reply to Jesse Litton from comment #2)
> > Also, the system tray icons for the following apps are all displaying blank
> > pages too:
> 
> I have a similar behavior with the system tray icon for the variety
> wallpaper changer, which I wasn't sure if it is related - the system tray
> icon is supposed to be a thumbnail of the current wallpaper image, but now -
> instead - it starts as the generic image icon and when the wallpaper changes
> (which would prompt an icon change), the icon becomes a blank page icon.

Yes - I believe it's likely the same underlying dependency:  Apps that set their tray icon from a file instead of the theme are broken.
Comment 6 Bug Janitor Service 2024-08-22 20:27:53 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1610
Comment 7 Nicolas Fella 2024-08-22 22:13:14 UTC
Git commit 5cfb3bb97213e7e5b4234143ceb5be4865be37a9 by Nicolas Fella.
Committed on 22/08/2024 at 20:27.
Pushed by cullmann into branch 'master'.

[icon] Only reload icon from theme if the theme has that icon

Otherwise we try to reload icons from absolute paths or non-standard search paths, which won't work
Related: bug 491806, bug 491854

M  +1    -1    src/primitives/icon.cpp

https://invent.kde.org/frameworks/kirigami/-/commit/5cfb3bb97213e7e5b4234143ceb5be4865be37a9
Comment 8 Jesse Litton 2024-08-22 22:38:10 UTC
Confirmed fixed.  Thanks!