Bug 491312 - "go down" icon in PlasmaComponents spinbox is incorrect
Summary: "go down" icon in PlasmaComponents spinbox is incorrect
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-05 17:07 UTC by TraceyC
Modified: 2024-08-07 18:07 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description TraceyC 2024-08-05 17:07:46 UTC
SUMMARY
In Panel Configuration, the icon for reducing the panel size appears to be using list-remove which is now a red X. It should be using a - symbol


STEPS TO REPRODUCE
1. Right click a panel and go to Panel Configuration
2. Look at the Panel Height option in Panel Settings

OBSERVED RESULT
The icon for decrease is incorrect
x - decrease (should be -)
+ - increase (correct)

EXPECTED RESULT

Icons are minus and plus

SOFTWARE/OS VERSIONS
Operating System: Solus 4.5
KDE Plasma Version: 6.1.80
KDE Frameworks Version: 6.5.0
Qt Version: 6.7.2
Kernel Version: 6.9.10-295.current (64-bit)
Graphics Platform: Wayland

ADDITIONAL INFORMATION
It looks like this was an underlying issue that was exposed by a recent MR that changed the list-remove icon to a red X
https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/388

The bug is not present on 6.1.3 where that MR is not merged in
Comment 1 Nate Graham 2024-08-05 19:13:20 UTC
Oh my goodness. Can reproduce. Will fix.
Comment 2 Bug Janitor Service 2024-08-05 19:53:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1176
Comment 3 Bug Janitor Service 2024-08-05 22:24:23 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/390
Comment 4 Bug Janitor Service 2024-08-05 22:24:54 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1177
Comment 5 Nate Graham 2024-08-06 13:35:58 UTC
Git commit 91114603ecf7f041769606e65bc3afe44a057e0d by Nate Graham.
Committed on 05/08/2024 at 22:18.
Pushed by ngraham into branch 'master'.

Spinbox: use more appropriate icons for decrease and increase buttons

Previously they were using the list-remove and list-add icons,
which was totally incorrect. It happened to work with Breeze icons
because they were plain minus and plus signs. ...Until recently, when
list-remove was changed to be an X, exposing the bug.

Instead, let's ask for dedicated spinbox-decrease and spinbox-increase
icons, which are being added to Breeze. If these don't exist, it will
fall back to the existing ones and nothing will change.

3rd-party icon themes might still exhibit the bug if their list-add or
list-remove icons look weird, but that's a pre-existing issue, and with
this, they'll at least have a path to fix it.
FIXED-IN: 6.1.4

M  +4    -2    src/declarativeimports/plasmacomponents3/SpinBox.qml

https://invent.kde.org/plasma/libplasma/-/commit/91114603ecf7f041769606e65bc3afe44a057e0d
Comment 6 Nate Graham 2024-08-06 13:39:20 UTC
Git commit 772f02540e653e5c5f92c9bbed94b981a757ca3b by Nate Graham.
Committed on 05/08/2024 at 22:12.
Pushed by ngraham into branch 'master'.

Add Spinbox-specific decrease and increase icons

In the past, the Plasma spinbox used list-remove and list-add, relying
on these icons looking like minus and plus icons. But that was fragile
and wrong, and when one of the icons changed, the spinbox icons started
looking nonsensical.

Instead, let's add dedicated icons for this in the icon theme, and ask
the spinbox to use those. We can use the fallback functionality to use
the old icons names for themes without these.

A  +13   -0    icons/actions/16/spinbox-decrease.svg
A  +1    -0    icons/actions/16/spinbox-increase.svg
A  +10   -0    icons/actions/22/spinbox-decrease.svg
A  +1    -0    icons/actions/22/spinbox-increase.svg

https://invent.kde.org/frameworks/breeze-icons/-/commit/772f02540e653e5c5f92c9bbed94b981a757ca3b
Comment 7 Nate Graham 2024-08-06 13:42:15 UTC
Git commit 3ba563b6aeb40ce19461367d6de8025f244f80b3 by Nate Graham.
Committed on 06/08/2024 at 13:36.
Pushed by ngraham into branch 'Plasma/6.1'.

Spinbox: use more appropriate icons for decrease and increase buttons

Previously they were using the list-remove and list-add icons,
which was totally incorrect. It happened to work with Breeze icons
because they were plain minus and plus signs. ...Until recently, when
list-remove was changed to be an X, exposing the bug.

Instead, let's ask for dedicated spinbox-decrease and spinbox-increase
icons, which are being added to Breeze. If these don't exist, it will
fall back to the existing ones and nothing will change.

3rd-party icon themes might still exhibit the bug if their list-add or
list-remove icons look weird, but that's a pre-existing issue, and with
this, they'll at least have a path to fix it.
FIXED-IN: 6.1.4


(cherry picked from commit 91114603ecf7f041769606e65bc3afe44a057e0d)

Co-authored-by: Nate Graham <nate@kde.org>

M  +4    -2    src/declarativeimports/plasmacomponents3/SpinBox.qml

https://invent.kde.org/plasma/libplasma/-/commit/3ba563b6aeb40ce19461367d6de8025f244f80b3
Comment 8 ratijas 2024-08-07 10:10:52 UTC
Question: why is this piece of SpinBox an icon and not an element of some spinbox.svg from Plasma theme?
Comment 9 Nate Graham 2024-08-07 18:07:42 UTC
Lack of a dedicated SVG for this, I suppose. If we added one to Breeze, it would be missing from 3rd-party themes so we'd need a fallback to some icon anyway.