Bug 491223 - Lack of padding in "Share" tab of Properties window
Summary: Lack of padding in "Share" tab of Properties window
Status: CONFIRMED
Alias: None
Product: kdenetwork-filesharing
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
: 488132 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-08-03 16:00 UTC by Patrick Silva
Modified: 2024-10-24 12:33 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (50.46 KB, image/png)
2024-08-03 16:00 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2024-08-03 16:00:43 UTC
Created attachment 172251 [details]
screenshot

STEPS TO REPRODUCE
1. right-click on a folder and choose "Properties"
2. click on "Share" tab
3. 

OBSERVED RESULT
lack of padding observed in the attached screenshot

EXPECTED RESULT
padding

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.1.3
KDE Frameworks Version: 6.4.0
Qt Version: 6.7.2
Graphics Platform: Wayland
Comment 1 Harald Sitter 2024-08-04 09:33:26 UTC
https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/20c6857f9c837e2e7e220074f57fdc68b68eaaa9 possibly this broke the margins? Paging Nate.

It looks like the Details tab is now also bugged - the text is squished against the top of the tab.
Comment 2 Nate Graham 2024-08-06 17:38:35 UTC
It looks like the content in this tab was expecting the view itself to provide padding, and that's now (intentionally) gone away due to turning on document mode in the tab bar to make the tabs touch the window edges. Looks like we need to add padding ourselves in the share tab's view.
Comment 3 Harald Sitter 2024-08-06 18:03:07 UTC
That seems like a poor runtime compatibility break to make in a framework.
Comment 4 Nate Graham 2024-08-06 19:36:55 UTC
It's a crappy situation where the wrapper UI (the properties dialog) lives in a framework, and it gets populated with content that comes from both Frameworks and Gear. Not sure how this could be done better without unifying release schedules.
Comment 5 Harald Sitter 2024-08-06 20:31:12 UTC
Interface versioning.

Essentially one would create KPropertiesDialogPluginV2 and deprecate KPropertiesDialogPlugin. Then at runtime qobject_cast<> the plugin to see if it implements V2, when that is the case it gets no spacing around, otherwise it's legacy and gets the spacing.
Comment 6 Nate Graham 2024-08-06 20:45:03 UTC
Sounds like a clever plan. Unfortunately that's not what was actually done, so here we are.
Comment 7 Harald Sitter 2024-10-24 12:33:07 UTC
*** Bug 488132 has been marked as a duplicate of this bug. ***