Bug 490306 - patch 4f3a8968 not working as intended
Summary: patch 4f3a8968 not working as intended
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: plasmoid (show other bugs)
Version: 24.05.2
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-15 14:11 UTC by Sergio
Modified: 2024-08-19 19:59 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio 2024-07-15 14:11:30 UTC
SUMMARY

Commit in subject, following 25.05.2 is meant for compatibility with modern openssh, but id does not appear to achieve the intended goal.

Browsing device connected via kdeconnect remains impossible since sshfs cannot mount.

The patch basically does away with the HostKeyAlgorithms and PubkeyAcceptedKeyTypes options from being passed to sshfs, but apparently they are needed, yet with different values.
Option values that work on my system are HostKeyAlgorithms=ssh-rsa and PubkeyAcceptedKeyTypes=+ssh-rsa. 

STEPS TO REPRODUCE
1.  Try to browse a device from a system with openssh 9.8p1

OBSERVED RESULT

Error on sshfs mount

EXPECTED RESULT

Device is browsed

SOFTWARE/OS VERSIONS

Operating System: Manjaro Linux 
KDE Plasma Version: 6.0.5
KDE Frameworks Version: 6.3.0
Qt Version: 6.7.1
Kernel Version: 6.9.5-1-MANJARO (64-bit)
Graphics Platform: Wayland

ADDITIONAL INFORMATION

N/A
Comment 1 Adrian Insaurralde 2024-07-21 17:18:40 UTC
I've seen a different patch proposed at manjaro forum: https://forum.manjaro.org/t/is-kdeconnect-file-browse-broken-again/165481/5 can this be included into kdeconnect?
Comment 2 Sergio 2024-07-21 17:21:45 UTC
That is what works for me.
Comment 3 Sergio 2024-07-21 17:24:41 UTC
... and what passes the options indicated above. Cannot test if other systems with different openssh versions, other android versions, or other kdeconnect versions on the android side may need anything different.
Comment 4 Albert Vaca Cintora 2024-07-21 21:36:06 UTC
This won't work until a new version of the Android app with this patch [1] is released. It might take one or two weeks still (which I assumed was fine given the change on the desktop side isn't officially released yet, if I'm not mistaken). Sorry for the inconvenience.

[1] https://invent.kde.org/network/kdeconnect-android/-/merge_requests/451
Comment 5 Sergio 2024-07-25 11:10:25 UTC
Shouldn't the patch at https://forum.manjaro.org/t/is-kdeconnect-file-browse-broken-again/165481/5 (transiently) work in all cases? Namely
old and new openssh on PC, old and new kdeconnect app on phone? Cannot test with new kdeconnect app on phone as I do not have it yet, but it should be the case.

If so, may I suggest transiently including that patch, to move to the current one later on?

Currently all distros shipping the new openssh (rolling linux releases including arch and all its derivatives) are broken because either:
1. they ship the current kdeconnect pc client that does not work with the newer openssh stack
2. they ship the current kdeconnect pc client with the still unreleased patch (arch and derivatives) that cannot anyway work with the current kdeconnect android client.

Also consider that there may be a time disalignment between the upgrade in the PC client and the phone (not just because of the timing of the android release on the play store, but also because some may need to pick the android app from alternate stores that may be slower, or because transient issues on phones can delay the upgrade. Limited memory can be a notable one, and in this case the irony is that one might want to use kdeconnect to transfer stuff elsewhere.
Comment 6 Adrian Insaurralde 2024-08-05 00:37:19 UTC
so there was a new android app release, has the patch been included? anyone has confirmed if it works?
Comment 7 Adrian Insaurralde 2024-08-05 00:54:43 UTC
tried now and it doesn't fix the issue :(
Comment 8 nmset 2024-08-19 19:59:57 UTC
(In reply to Adrian Insaurralde from comment #6)
> so there was a new android app release, has the patch been included? anyone
> has confirmed if it works?

I installed the new Android app today, kdeconnect works seamlessly with openssh 9.8p1-1 and kdeconnect 24.05.2-2 on Arch on all tested scenarios (rebooting, killing on each device).