Bug 490020 - Deleting a time interval from the timeline should reasonably handle markers and keyframes; at least shift left all those after the deleted time
Summary: Deleting a time interval from the timeline should reasonably handle markers a...
Status: RESOLVED WORKSFORME
Alias: None
Product: kdenlive
Classification: Applications
Component: Video Effects & Transitions (show other bugs)
Version: 24.05.0
Platform: unspecified All
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-10 14:16 UTC by info
Modified: 2024-09-08 03:46 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description info 2024-07-10 14:16:59 UTC
SUMMARY

Deleting some time intervall completely from the timeline should update the position of all markers and keyframes AFTER the deleted part, and (possibly), and delete all markers IN the deleted time, and usefully update OR delete all keyframes IN the deleted time.
Currently it does NOT change them. So keyframes and 

Besides, the naming of the German and English menu entries for these timeline functions are not optimal (other functions not yet reviewed).

STEPS TO REPRODUCE

1. Have any project with markers and/or keyframes
2. Select some time interval in the timeline. Then chose:
English: Timeline - Removal - Extract timeline zone
German: Zeitleiste - Entfernen - Zeitleistenbereich extrahieren


OBSERVED RESULT

The audio and video elements IN the selected "timeline zone" are removed. This is ok.
All audio and video elements AFTER the selected "timeline zone" are shifted left by the time equivalent to the duration of removed time interval. This is ok.

I do not know what happens to markers and keyframes IN the selected "timeline zone".

The markers and keyframes AFTER the removed timeline zone, however, remain completely unchanged.
So afterwards, these markers mark wrong and meaningless positions.
And the keyframes cause effect changes at wrong and meaningless positions.

EXPECTED RESULT
All markers AND keyframes AFTER the removed "timeline zone" should be shifted left by the time equivalent of the duration of the removed time interval. (This is the bare minimum :-)  )

All markers IN the removed timeline zone should probably be deleted. (This might already happen.)

The first and the last keyframe of any given effect IN the removed "timeline zone" should most probably be replaced by two keyframes at the last frame before the excision, and at the first frame after the excision (these two should be neighbouring frames); probably with interpolated values for keyframe data that would have applied to the same positions BEFORE the excision of a time zone was performed.
OR - they might just as well be merely deleted (less graceful...), so that any interpolation across the deleted time might remain seamlessly intact.
OR - a dialog or a further submenu should offer various options.

SOFTWARE/OS VERSIONS
All versions are probably affected.

ADDITIONAL INFORMATION
The naming of the menu items do NOT optimal in both German and English.

I'd suggest the following changes (to make it clear that one option removes time, and the other removes content):

English:
Timeline Zone -> Time interval
Extract Timeline Zone -> Remove time interval from the timeline
Lift Timeline Zone -> Free time interval from content

German:
Zeitleistenbereich -> Zeitintervall
Zeitleistenbereich extrahieren -> Zeitintervall aus der Zeitleiste löschen
Zeitleistenbereich herausheben -> Inhalte im Zeitintervall entfernen

The best choice between "Remove, Cut, Delete" may depend on whether the removed portion actually goes to the clipboard, or just vanishes.
Comment 1 info 2024-07-10 14:19:54 UTC
(Sorry for the garbled sentences in the summary, I can't edit that, but hope the problem is still clear.)
Comment 2 info 2024-07-10 14:23:00 UTC
You could also use the word "Excise" in English, or "Herausschneiden" in German (instead of Extract/Extrahieren).
Comment 3 Jean-Baptiste Mardelle 2024-08-09 05:22:14 UTC
Git commit a71297e64a608b9fcfe433953ddf4b7c7d38b46b by Jean-Baptiste Mardelle.
Committed on 09/08/2024 at 05:21.
Pushed by mardelle into branch 'release/24.08'.

When doing an extract operation on all tracks and guides are not locked, move / delete the guides accordingly.

M  +23   -3    src/timeline2/view/timelinecontroller.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/a71297e64a608b9fcfe433953ddf4b7c7d38b46b
Comment 4 Jean-Baptiste Mardelle 2024-08-09 05:26:43 UTC
Thanks for your report. The guides will now move accordingly to the Extract operation, this will be in the 24.08 version. Extract and Lift are standard terms in video editing, so we will probably keep as is in english.

Regarding keyframes, it works for keyframes in clip effects. Are you talking about track effects ?
Comment 5 Bug Janitor Service 2024-08-24 03:47:33 UTC
🐛🧹 ⚠️ This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information, then set the bug status to REPORTED. If there is no change for at least 30 days, it will be automatically closed as RESOLVED WORKSFORME.

For more information about our bug triaging procedures, please read https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Bug Janitor Service 2024-09-08 03:46:57 UTC
🐛🧹 This bug has been in NEEDSINFO status with no change for at least 30 days. Closing as RESOLVED WORKSFORME.