Bug 489357 - The title of OverlaySheet is not vertically center aligned
Summary: The title of OverlaySheet is not vertically center aligned
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Other Other
: NOR minor
Target Milestone: Not decided
Assignee: kdelibs bugs
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-06-28 07:10 UTC by Fushan Wen
Modified: 2024-10-07 08:06 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kirigami/-/commit/f99c00fc421b44336b51063db50d15e403db4974
Version Fixed In: 6.7
Sentry Crash Report:

Attachments
overlaysheet.png (101.15 KB, image/png)
2024-06-28 07:10 UTC, Fushan Wen 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Fushan Wen 2024-06-28 07:10:13 UTC 
Created attachment 171115 [details]
overlaysheet.png

See the screenshot for details
Comment 1 Nate Graham 2024-07-02 23:07:14 UTC 
Can confirm.
Comment 2 Bug Janitor Service 2024-09-30 07:29:07 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/1627
Comment 3 Fushan Wen 2024-09-30 14:57:56 UTC 
Git commit 3cd858b861fe6a5a98152f97adf2ab120e5ba3eb by Fushan Wen.
Committed on 30/09/2024 at 07:27.
Pushed by fusionfuture into branch 'master'.

OverlaySheet: make default title vertically center aligned

M  +1    -0    src/controls/templates/OverlaySheet.qml

https://invent.kde.org/frameworks/kirigami/-/commit/3cd858b861fe6a5a98152f97adf2ab120e5ba3eb
Comment 4 Marco Martin 2024-10-07 08:06:03 UTC 
Git commit f99c00fc421b44336b51063db50d15e403db4974 by Marco Martin.
Committed on 07/10/2024 at 08:05.
Pushed by mart into branch 'master'.

Make OverlaySheet look exactly like Dialog

There is no reason that OverlaySheet looks any different from any Dialog.
as is a dialog in itself, just that has much better interaction on touchscreen, especially when used in itemviews

Make Overlaysheet look pixel by pixel the same as the default look of
dialogs,

Also, is properly modal now

![Screenshot_20240925_051914](/uploads/3cabdfc306f14bc6e8b84e392c4714a2/Screenshot_20240925_051914.png)

M  +38   -55   src/controls/templates/OverlaySheet.qml

https://invent.kde.org/frameworks/kirigami/-/commit/f99c00fc421b44336b51063db50d15e403db4974