Bug 489209 - ed05004b033950a4715ca7f0085198d2bed5b895 breaks focusing the search field by default
Summary: ed05004b033950a4715ca7f0085198d2bed5b895 breaks focusing the search field by ...
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: sidebarview (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-06-26 01:07 UTC by Nate Graham
Modified: 2024-06-26 18:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-06-26 01:07:37 UTC
I don't understand why though.

It seems like *nothing* gets focus at all, and the tab key can't be used to focus something.
Comment 1 Akseli Lahtinen 2024-06-26 11:18:59 UTC
Can confirm.

In SubCategoryPage.qml the `subCategoryView.forceActiveFocus();` eats the focus at startup, since subcategory is changed from the list of items instead of the button.

Whenever that call is done, the search field never gets focused again (which seems to be another bug, not because of these changes).
Comment 2 Nate Graham 2024-06-26 17:39:37 UTC
Thanks, that was really helpful!
Comment 3 Bug Janitor Service 2024-06-26 17:44:09 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/321
Comment 4 Nate Graham 2024-06-26 18:04:00 UTC
Git commit 8931ccd1f12cabb425c33b7df30d14e96c295d82 by Nate Graham.
Committed on 26/06/2024 at 17:39.
Pushed by ngraham into branch 'master'.

Force focus to subcategory page only when actually needed

Previously we were forcing focus to it anytime it existed, even if it
did not have enough items to become visible. This bug was masked by the
previous code, which popped the subcategory column explicitly when
showing the intro page. Removing that in
ed05004b033950a4715ca7f0085198d2bed5b895 exposed the bug, which is fixed
in this commit.

M  +1    -1    app/qml/SubCategoryPage.qml

https://invent.kde.org/plasma/systemsettings/-/commit/8931ccd1f12cabb425c33b7df30d14e96c295d82