Bug 489099 - Keyboard navigation with up arrow key is broken since reorg of switch
Summary: Keyboard navigation with up arrow key is broken since reorg of switch
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Power and Battery widget (show other bugs)
Version: 6.1.0
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-06-24 11:53 UTC by Christian (Fuchs)
Modified: 2025-02-10 20:40 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.3.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2024-06-24 11:53:11 UTC
SUMMARY
Since re-ordering the inhibit action from the header into the plasmoid (why?) keyboard navigation is now broken.
The down arrow works as expected, the up arrow depends on what item the focus is currently at, but it's wrong.

STEPS TO REPRODUCE
1.  Update to plasma >= 6.1
2.  Open the battery plasmoid
3.  Try to navigate by keyboard

OBSERVED RESULT
Up arrow doesn't work as it's still bound to the old layout

EXPECTED RESULT
Keys work as expected
Comment 1 Nate Graham 2024-06-25 15:55:41 UTC
Can confirm. I'll see if I can fix it sometime soon.
Comment 2 Bug Janitor Service 2025-02-07 19:37:36 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/powerdevil/-/merge_requests/507
Comment 3 Ismael Asensio 2025-02-10 20:32:00 UTC
Git commit f7b5559a4cf88eff7d7c0f509b7e56aea5a5d2d1 by Ismael Asensio.
Committed on 10/02/2025 at 20:28.
Pushed by iasensio into branch 'master'.

applets/battery: Fix navigation keyboard cycle for the Up key

When on the first item of the battery list, trying to force focus
to the header item fails, probably because it is wrapped within a
Column.

Just setting it to `null` works in this case, since it automatically
completes the `KeyNavigation.down` chain, but in reverse. This is
the same trick already being used in the footer.
FIXED-IN: 6.3.1

M  +1    -1    applets/batterymonitor/package/contents/ui/PopupDialog.qml

https://invent.kde.org/plasma/powerdevil/-/commit/f7b5559a4cf88eff7d7c0f509b7e56aea5a5d2d1
Comment 4 Ismael Asensio 2025-02-10 20:40:15 UTC
Git commit 241b7b7d6d0ee95b2c8d95016e198f8d8770e6c5 by Ismael Asensio.
Committed on 10/02/2025 at 20:34.
Pushed by iasensio into branch 'Plasma/6.3'.

applets/battery: Fix navigation keyboard cycle for the Up key

When on the first item of the battery list, trying to force focus
to the header item fails, probably because it is wrapped within a
Column.

Just setting it to `null` works in this case, since it automatically
completes the `KeyNavigation.down` chain, but in reverse. This is
the same trick already being used in the footer.
FIXED-IN: 6.3.1


(cherry picked from commit f7b5559a4cf88eff7d7c0f509b7e56aea5a5d2d1)

Co-authored-by: Ismael Asensio <isma.af@gmail.com>

M  +1    -1    applets/batterymonitor/package/contents/ui/PopupDialog.qml

https://invent.kde.org/plasma/powerdevil/-/commit/241b7b7d6d0ee95b2c8d95016e198f8d8770e6c5