Bug 488920 - In Edit Mode, the toolbar buttons at the top of the scaled-down desktop preview have blurry icons and inconsistent hover outline thicknesses
Summary: In Edit Mode, the toolbar buttons at the top of the scaled-down desktop previ...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Edit Mode (show other bugs)
Version: 6.1.0
Platform: Manjaro Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
: 488919 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-06-21 19:57 UTC by medin
Modified: 2024-07-05 18:24 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/6626ad46caaaf8b5147fbdf1ddc539788f41f98e
Version Fixed In: 6.1.3
Sentry Crash Report:

Attachments
Distorted border (22.78 KB, image/png)
2024-06-21 19:57 UTC, medin 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description medin 2024-06-21 19:57:08 UTC 
Created attachment 170779 [details]
Distorted border

In the new edit mode, the border that is displayed when you hover the mouse over buttons is distorted. See attached image for more information.

Operating System: Manjaro Linux 
KDE Plasma Version: 6.1.0
KDE Frameworks Version: 6.3.0
Qt Version: 6.7.1
Kernel Version: 6.9.5-1-MANJARO (64-bit)
Graphics Platform: Wayland
Comment 1 Nate Graham 2024-06-25 20:19:38 UTC 
What are your scale factor and screen resolution?
Comment 2 medin 2024-06-25 21:13:49 UTC 
(In reply to Nate Graham from comment #1)
> What are your scale factor and screen resolution?

This only happens on two laptops with 100% scale and 1366*768.
Comment 3 Nate Graham 2024-06-26 21:15:07 UTC 
I can reproduce the issue. It's subtle on my 4k screen at 225% scale, but visibly present. I suspect when we scale down the desktop, we don't round it to pixels, causing blurriness. I see the icons are slightly blurry too, as reported in Bug 488919. Seems like two instances of the same root cause.
Comment 4 Nate Graham 2024-06-26 21:15:22 UTC 
*** Bug 488919 has been marked as a duplicate of this bug. ***
Comment 5 Bug Janitor Service 2024-07-01 09:55:58 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2355
Comment 6 Akseli Lahtinen 2024-07-02 14:20:12 UTC 
Git commit 0c3d09285dfd01729b3bbef4b0e969ccda73f388 by Akseli Lahtinen.
Committed on 02/07/2024 at 14:20.
Pushed by akselmo into branch 'master'.

Edit Mode: Fix for blurry icons

A fix for blurry icons and elements in the edit mode.
This makes sure the elements are always rounded to pixel size.

M  +14   -13   desktoppackage/contents/views/DesktopEditMode.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/0c3d09285dfd01729b3bbef4b0e969ccda73f388
Comment 7 Akseli Lahtinen 2024-07-02 14:37:41 UTC 
Git commit 6626ad46caaaf8b5147fbdf1ddc539788f41f98e by Akseli Lahtinen.
Committed on 02/07/2024 at 14:26.
Pushed by akselmo into branch 'Plasma/6.1'.

Edit Mode: Fix for blurry icons

A fix for blurry icons and elements in the edit mode.
This makes sure the elements are always rounded to pixel size.


(cherry picked from commit 0c3d09285dfd01729b3bbef4b0e969ccda73f388)

fa3295e1 Edit Mode: Potential fix for blurry icons
6665768a Fix position rounding
3914e8d9 Round all the things
1d6554d5 Set roundedRootWidth and height property, fix binding loop

Co-authored-by: Akseli Lahtinen <akselmo@akselmo.dev>

M  +14   -13   desktoppackage/contents/views/DesktopEditMode.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/6626ad46caaaf8b5147fbdf1ddc539788f41f98e