Bug 488676 - With default favorites, KCM runner can pollute search results that unintentionally match KCM keywords
Summary: With default favorites, KCM runner can pollute search results that unintentio...
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: general (show other bugs)
Version: 6.1.0
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2024-06-18 17:00 UTC by Fabian Vogt
Modified: 2024-07-27 09:13 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2024-06-18 17:00:41 UTC
Found by openQA: https://openqa.opensuse.org/tests/4277215#step/kontact/19

Typing "akonadictl start" into krunner shows "Systemsettings autostart" as the top hit. I assume that's because systemsetting is set as favorite runner by default and "start" matches "autostart". The "akonadictl" word should cause it to not match at all though IMO.
Comment 1 Nate Graham 2024-06-19 19:34:17 UTC
Seems intentional based on having the System Settings runner a favorite. I guess we could make the command runner a favorite too and put it higher, but then at a certain point we're re-implementing the internal priority ordering, but in a user-facing way.

Ultimately maybe that's what we should do, so that the internal ordering stuff only affects the order of items shown *within* a category, and not the order of categories themselves. Because right now we have two sources of truth and it's gonna get messy.
Comment 2 Fabian Vogt 2024-06-20 09:22:39 UTC
(In reply to Nate Graham from comment #1)
> Seems intentional based on having the System Settings runner a favorite.

For ordering yes, but why does it match even though the kcm has nothing to to with "akonadictl"?

> I
> guess we could make the command runner a favorite too and put it higher, but
> then at a certain point we're re-implementing the internal priority
> ordering, but in a user-facing way.
> 
> Ultimately maybe that's what we should do, so that the internal ordering
> stuff only affects the order of items shown *within* a category, and not the
> order of categories themselves. Because right now we have two sources of
> truth and it's gonna get messy.
Comment 3 Bug Janitor Service 2024-06-21 18:46:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/systemsettings/-/merge_requests/318
Comment 4 Fabian Vogt 2024-07-24 07:30:36 UTC
Git commit bb9c3442348d08b971b6123d915add66f0aa3232 by Fabian Vogt.
Committed on 24/07/2024 at 07:29.
Pushed by fvogt into branch 'master'.

runner: Don't match if just one query word matches

If someone types in "foo asdf start bar", it should not show the autostart
KCM for instance.

This runner is part of the default favorites in Plasma 6.1, so it's
shown above others and must avoid polluting results.

M  +6    -6    runner/systemsettingsrunner.cpp

https://invent.kde.org/plasma/systemsettings/-/commit/bb9c3442348d08b971b6123d915add66f0aa3232
Comment 5 Fabian Vogt 2024-07-24 07:32:55 UTC
Git commit 4f22c7378dae2d8c0545a8ef85cd20a6244dea53 by Fabian Vogt.
Committed on 24/07/2024 at 07:32.
Pushed by fvogt into branch 'Plasma/6.1'.

runner: Don't match if just one query word matches

If someone types in "foo asdf start bar", it should not show the autostart
KCM for instance.

This runner is part of the default favorites in Plasma 6.1, so it's
shown above others and must avoid polluting results.


(cherry picked from commit bb9c3442348d08b971b6123d915add66f0aa3232)

Co-authored-by: Fabian Vogt <fabian@ritter-vogt.de>

M  +6    -6    runner/systemsettingsrunner.cpp

https://invent.kde.org/plasma/systemsettings/-/commit/4f22c7378dae2d8c0545a8ef85cd20a6244dea53