Bug 488675 - Missing informational dialog about fullscreening a window
Summary: Missing informational dialog about fullscreening a window
Status: RESOLVED WORKSFORME
Alias: None
Product: kwin
Classification: Plasma
Component: core (other bugs)
Version First Reported In: 6.1.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-18 16:18 UTC by Fabian Vogt
Modified: 2024-06-27 19:00 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2024-06-18 16:18:44 UTC
Found by openQA: https://openqa.opensuse.org/tests/4277216#step/live_installation/29

When using the window menu (alt-f3) to force a window to fullscreen, previous versions had a dialog that explained how to go back, as it's not obvious: https://openqa.opensuse.org/tests/4277983#step/live_installation/37

With kwin 6.1.0, that dialog appears to be gone.
Comment 1 fanzhuyifan 2024-06-18 21:14:08 UTC
Fwiw cannot reproduce on master, wayland -- the dialog is still shown.
Comment 2 Vlad Zahorodnii 2024-06-19 06:43:32 UTC
Is it an X and a Wayland client? xdg-toplevel windows are assumed to support fullscreen mode (unless the plasma surface extension is installed which changes the window type), so you're unlikely to see the dialog for wayland windows. X11 apps should be still fine.
Comment 3 Fabian Vogt 2024-06-19 12:14:25 UTC
(In reply to Vlad Zahorodnii from comment #2)
> Is it an X and a Wayland client? xdg-toplevel windows are assumed to support
> fullscreen mode (unless the plasma surface extension is installed which
> changes the window type), so you're unlikely to see the dialog for wayland
> windows. X11 apps should be still fine.

X11 I think. It's a Qt 5 application launched through xdg-su.
Comment 4 Vlad Zahorodnii 2024-06-19 12:24:16 UTC
(In reply to Fabian Vogt from comment #3)
> (In reply to Vlad Zahorodnii from comment #2)
> > Is it an X and a Wayland client? xdg-toplevel windows are assumed to support
> > fullscreen mode (unless the plasma surface extension is installed which
> > changes the window type), so you're unlikely to see the dialog for wayland
> > windows. X11 apps should be still fine.
> 
> X11 I think. It's a Qt 5 application launched through xdg-su.

Can you check the fullScreenable property of that window in kwin debug console?
Comment 5 Fabian Vogt 2024-06-19 12:37:11 UTC
(In reply to Vlad Zahorodnii from comment #4)
> (In reply to Fabian Vogt from comment #3)
> > (In reply to Vlad Zahorodnii from comment #2)
> > > Is it an X and a Wayland client? xdg-toplevel windows are assumed to support
> > > fullscreen mode (unless the plasma surface extension is installed which
> > > changes the window type), so you're unlikely to see the dialog for wayland
> > > windows. X11 apps should be still fine.
> > 
> > X11 I think. It's a Qt 5 application launched through xdg-su.
> 
> Can you check the fullScreenable property of that window in kwin debug
> console?

It's true.

I just fullscreened the window with the debug console open and the dialog actually showed up. Maybe it's just behind the fullscreened window? I'm also not able to reproduce it manually ATM, I think I only managed it once. Could it be a race condition?
Comment 6 Vlad Zahorodnii 2024-06-19 12:38:02 UTC
The dialog will be shown only if fullScreenable == false
Comment 7 Vlad Zahorodnii 2024-06-19 12:42:09 UTC
MIght be a regression after https://invent.kde.org/plasma/kwin/-/commit/d25574e7c67d39b4583c613bb90ebc0fb636738f but Plasma/6.0 includes that change as well
Comment 8 Vlad Zahorodnii 2024-06-19 12:46:16 UTC
(In reply to Vlad Zahorodnii from comment #6)
> The dialog will be shown only if fullScreenable == false

scratch that, I'm talking nonsense
Comment 9 Vlad Zahorodnii 2024-06-19 12:49:56 UTC
kwin indeed attempts to show the dialog. maybe kdialog is broken
Comment 10 Vlad Zahorodnii 2024-06-19 12:59:22 UTC
kdialog was broken on my machine.
Comment 11 Bug Janitor Service 2024-06-19 13:15:21 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5947
Comment 12 Vlad Zahorodnii 2024-06-27 09:17:29 UTC
Can you check that kdialog is working as expected or that it's installed?
Comment 13 Fabian Vogt 2024-06-27 16:22:55 UTC
(In reply to Vlad Zahorodnii from comment #12)
> Can you check that kdialog is working as expected or that it's installed?

Works fine. Meanwhile I've seen some openQA runs where the dialog appears. I'll schedule some more tests with some changed settings, maybe I can spot a pattern.
Comment 14 Fabian Vogt 2024-06-27 19:00:56 UTC
(In reply to Fabian Vogt from comment #13)
> (In reply to Vlad Zahorodnii from comment #12)
> > Can you check that kdialog is working as expected or that it's installed?
> 
> Works fine. Meanwhile I've seen some openQA runs where the dialog appears.
> I'll schedule some more tests with some changed settings, maybe I can spot a
> pattern.

I threw more RAM at it (from 2G to 3G) and it showed up in 4/4 runs.

AFAICT it shouldn't need that much to run, so I'll try to investigate what's hogging RAM use. Meanwhile I'll close it as WORKSFORME.