Bug 488619 - With 17-6-2024 git master everything, all notification pop-ups are positioned in top-left corner
Summary: With 17-6-2024 git master everything, all notification pop-ups are positioned...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: master
Platform: Other Linux
: VHI normal
Target Milestone: 1.0
Assignee: Marco Martin
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-06-17 13:46 UTC by Nate Graham
Modified: 2024-06-27 07:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-06-17 13:46:13 UTC
This is a regression from 14-6-2024 git master.

Symptoms are:
- All pop-ups appear in the top-left screen corner
- All user-visible positioning options are ignored
- Notifications overlap one another rather than appearing in a vertical column
Comment 1 Nate Graham 2024-06-17 13:46:55 UTC
Others can reproduce it too; marking as CONFIRMED and bumping priority.
Comment 2 Nate Graham 2024-06-17 13:48:31 UTC
This is caused by https://invent.kde.org/plasma/plasma-workspace/-/commit/009136c8c4f02d19f1a1ba40b28c5d8960235487; reverting that fixes the issue.
Comment 3 Nate Graham 2024-06-17 14:01:17 UTC
That commit was reverted, so this is fixed now.
Comment 4 Marco Martin 2024-06-27 07:50:44 UTC
Git commit 9c872a54287a1ea84326a71001386e4040b7c5a4 by Marco Martin.
Committed on 27/06/2024 at 07:50.
Pushed by mart into branch 'master'.

applets/systemtray: Fix shortcut activation for hidden applets

The systray applet was opened by a connection to activated in the
PlasmoidItem container element. This element is a delegate, of a Repeater
for active applets, and for the internal GridView in the popup for the passive applets.

Being a Delegate we can't be guaranteed it will be instantiated at startup,
in particular it won't be unless the first time the gridview is visible,
so the connections to the activated signal won't work until the first time the
applet is open. Also, if there would ever be enough icons in the popup to
cause a scrollbar, it will destroy the PopupItems out of view.

Move the connection to the activate signal that will cause the popup to open
inside an Instantiator in the main qml file: with an Instantiator we will always
be guaranteed every delegate (which is just a Connections)
will always be instantiated all the time

Depends on https://invent.kde.org/plasma/libplasma/-/merge_requests/1145
Related: bug 480173
FIXED-IN: 6.2

M  +1    -8    applets/systemtray/package/contents/ui/HiddenItemsView.qml
M  +0    -1    applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
M  +59   -8    applets/systemtray/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/9c872a54287a1ea84326a71001386e4040b7c5a4