Bug 488429 - When in panel Edit Mode, clicking on configure on a widget should also exit from global Edit Mode
Summary: When in panel Edit Mode, clicking on configure on a widget should also exit f...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Edit Mode (other bugs)
Version First Reported In: master
Platform: Other Linux
: NOR wishlist
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6, usability
Depends on:
Blocks:
 
Reported: 2024-06-12 20:15 UTC by dmatteo002
Modified: 2024-08-16 19:25 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.2.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dmatteo002 2024-06-12 20:15:21 UTC
SUMMARY
When in Edit Mode, clicking on configure on a widget open a windows without closing edit mode.

STEPS TO REPRODUCE
1. Open Edit mode (or panel edit mode)
2. Right click onto a widget with configure action
3. Click "configure ..." option

OBSERVED RESULT
It open the window over the edit mode.

EXPECTED RESULT
It should open the window and close edit mode. This is what already happens if opening windows using Global Edit Mode Toolbar (ex. display configuration button,...).

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.1.80
KDE Frameworks Version: 6.4.0
Qt Version: 6.7.1
Kernel Version: 6.9.3-arch1-1 (64-bit)
Graphics Platform: Wayland
Comment 1 dmatteo002 2024-06-14 18:41:51 UTC
Update:
1. "desktop and wallpaper" button: open window and change from panel edit mode (if inside it) to global edit mode
2. "global theme", "display configuration" and "panel and desktop management" button: open window closing edit mode in general
3. widget -> "configure ...": open windows and does close nothing

When using last option it open a window that can be partially hidden by the "Panel Setting" and when clicking on it it will pass from Panel Edit Mode to global Edit Mode

I think that this behaviour should be consistent. Also I think that the more sane option is to completly close the edit mode.
Comment 2 Bug Janitor Service 2024-08-15 10:29:25 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4609
Comment 3 Niccolò Venerandi 2024-08-16 14:40:51 UTC
Git commit fc2c0cba0b8d1415d81e058bbc1bc4351453bad1 by Niccolò Venerandi.
Committed on 16/08/2024 at 12:58.
Pushed by niccolove into branch 'master'.

Close Edit Mode when opening applet or desktop config window

M  +2    -0    shell/desktopview.cpp
M  +1    -0    shell/panelview.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/fc2c0cba0b8d1415d81e058bbc1bc4351453bad1