Bug 488365 - It's unnecessary for the System Tray icon to enter the active state when there's an open connection
Summary: It's unnecessary for the System Tray icon to enter the active state when ther...
Status: RESOLVED FIXED
Alias: None
Product: KRdp
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2024-06-11 15:47 UTC by Nate Graham
Modified: 2024-06-13 14:34 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.1.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-06-11 15:47:17 UTC
Right now the tray icon is passive when there's no connection, and active when there is a connection. This is unnecessary because when there is a connection, the portal *also* shows a tray icon, which offers more information too. It's awkward to have multiple system tray icons for the same thing.
Comment 1 Arjen Hiemstra 2024-06-12 11:20:32 UTC
Personally I'd rather get rid of the portal SNI and enhance the server SNI a bit. The portal SNI doesn't even indicate *which* application requested access, whereas we can show stuff like which client is connected in the server SNI.

Also note that the one action from the portal SNI doesn't quit the server, it just breaks whatever active connection is there.
Comment 2 Bug Janitor Service 2024-06-13 10:39:09 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/krdp/-/merge_requests/39
Comment 3 Nate Graham 2024-06-13 14:32:57 UTC
Git commit a4f25f535035601cb11cf7d494d15e5c675a0d10 by Nate Graham, on behalf of Akseli Lahtinen.
Committed on 13/06/2024 at 14:32.
Pushed by ngraham into branch 'master'.

SessionController: remove SNI status; keep it always passive

Since the portal SNI is the one indicating if connection is active
or not, remove the SNI status. No need for two SNIs to be active.

Ideally we only would have one anyway, but this a workaround
until we can reuse the SNI for the portal status as well.
FIXED-IN: 6.1.1

M  +0    -26   server/SessionController.cpp

https://invent.kde.org/plasma/krdp/-/commit/a4f25f535035601cb11cf7d494d15e5c675a0d10
Comment 4 Nate Graham 2024-06-13 14:34:14 UTC
Git commit e778e26588862e1cda0f40e70f92c21481b70675 by Nate Graham.
Committed on 13/06/2024 at 14:33.
Pushed by ngraham into branch 'Plasma/6.1'.

SessionController: remove SNI status; keep it always passive

Since the portal SNI is the one indicating if connection is active
or not, remove the SNI status. No need for two SNIs to be active.

Ideally we only would have one anyway, but this a workaround
until we can reuse the SNI for the portal status as well.
FIXED-IN: 6.1.1


(cherry picked from commit a4f25f535035601cb11cf7d494d15e5c675a0d10)

75114bbd SessionController: remove sni status, keep it always passive

Co-authored-by: Akseli Lahtinen <akselmo@akselmo.dev>

M  +0    -26   server/SessionController.cpp

https://invent.kde.org/plasma/krdp/-/commit/e778e26588862e1cda0f40e70f92c21481b70675