Bug 488359 - Pointless confirmation dialog when trying to quit the server from the System Tray icon
Summary: Pointless confirmation dialog when trying to quit the server from the System ...
Status: RESOLVED FIXED
Alias: None
Product: KRdp
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2024-06-11 15:10 UTC by Nate Graham
Modified: 2024-06-13 15:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.1.1
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2024-06-11 15:10:47 UTC
When I right-click on the server item in my system tray, it asks for confirmation. This is pointless and annoying. If I was able to muster the precision mousing skills required to right-click on a 22x22 icon and then left-click on a tiny menu item, of course I meant to do that! :) So don't ask for confirmation.
Comment 1 Bug Janitor Service 2024-06-13 10:30:18 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/krdp/-/merge_requests/38
Comment 2 Akseli Lahtinen 2024-06-13 15:06:31 UTC
Git commit c6c58fb9059610d67456ca9b52fd8ee80326c4b4 by Akseli Lahtinen.
Committed on 13/06/2024 at 15:06.
Pushed by akselmo into branch 'master'.

SessionController: instead of using default quit action, implement our own

This will skip the confirmation dialog popup and also
handle the shutdown more gracefully since it will
talk to dbus first before exiting.

Earlier we were using the default action which was not correct way
to do this.
Related: bug 488362

M  +9    -2    server/SessionController.cpp

https://invent.kde.org/plasma/krdp/-/commit/c6c58fb9059610d67456ca9b52fd8ee80326c4b4
Comment 3 Akseli Lahtinen 2024-06-13 15:07:38 UTC
Git commit dd956081c8a3158366cc99410b70e6af2344276b by Akseli Lahtinen.
Committed on 13/06/2024 at 15:06.
Pushed by akselmo into branch 'Plasma/6.1'.

SessionController: instead of using default quit action, implement our own

This will skip the confirmation dialog popup and also
handle the shutdown more gracefully since it will
talk to dbus first before exiting.

Earlier we were using the default action which was not correct way
to do this.
Related: bug 488362


(cherry picked from commit c6c58fb9059610d67456ca9b52fd8ee80326c4b4)

159645e5 SessionController: instead of using default quit action, implement our own
a56b0b95 Use qcoreapplication quit
bb76e487 Use local variable for menu

Co-authored-by: Akseli Lahtinen <akselmo@akselmo.dev>

M  +9    -2    server/SessionController.cpp

https://invent.kde.org/plasma/krdp/-/commit/dd956081c8a3158366cc99410b70e6af2344276b