Bug 487546 - Clicking on "add widget" in the topbar of edit mode does not always close the panel configuration (expecially if panel edit mode was open from edit mode)
Summary: Clicking on "add widget" in the topbar of edit mode does not always close the...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Containment (show other bugs)
Version: git-stable-Plasma/6.1
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: dmatteo002
URL:
Keywords: usability
: 488944 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-05-25 20:13 UTC by dmatteo002
Modified: 2024-07-22 21:22 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.2.0
Sentry Crash Report:


Attachments
extreme example of result (669.03 KB, image/png)
2024-05-25 20:18 UTC, dmatteo002
Details
video of trying to get problem (2.20 MB, video/webm)
2024-06-12 08:26 UTC, dmatteo002
Details
Happened to me too (708.20 KB, image/png)
2024-06-14 21:28 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description dmatteo002 2024-05-25 20:13:58 UTC
SUMMARY
There are two way to open the Add widget sidebar in edit mode. One is using the button in the topbar and the second (which is in my opinion reduntant) in the new panel settings. 

The problem is that while the first button doesn't close the new panel settings (making the desktop very small) the second temporary hide the new panel setting.

STEPS TO REPRODUCE
1. Open panel edit mode
2. Try both button with "add widget"

OBSERVED RESULT
The button in the global toolbar doesn't close the new panel settings (making the desktop very small) the other temporary hide the new panel setting.

EXPECTED RESULT
Both should hide (or close going back to global edit mode) the new panel settings.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 6.0.90
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.1
Kernel Version: 6.9.1-arch1-2 (64-bit)
Graphics Platform: Wayland

ADDITIONAL INFORMATION
none
Comment 1 dmatteo002 2024-05-25 20:18:39 UTC
Created attachment 169832 [details]
extreme example of result
Comment 2 Niccolò Venerandi 2024-05-31 08:33:48 UTC

*** This bug has been marked as a duplicate of bug 481380 ***
Comment 3 dmatteo002 2024-05-31 17:23:45 UTC
Wrongly marked as duplicate of another bug . The other bug is related to panel hiding in other screen, this is related to edit mode.
Comment 4 Niccolò Venerandi 2024-06-03 10:41:01 UTC
Sorry, that must've been a misclick of mine!
Comment 5 Nate Graham 2024-06-11 20:45:31 UTC
The buttons do different things. The one on the top bar adds it to the desktop, while the one on the panel configuration dialog adds it to the dialog's panel.

I can't reproduce the issue: when the panel config dialog is open, if I click "Add Widgets" from the top bar, the panel config dialog disappears. Can you attach a screen recording that shows the issue?
Comment 6 dmatteo002 2024-06-12 08:26:05 UTC
Created attachment 170406 [details]
video of trying to get problem

You are right that they do different thing by clicking on them but i think it is not communicated well enough. Expecially because from both of them i can drag the widget to any place i want to add it. And also because the two view are not differentiated neither by the title.

About the not closing of the panel setting the new step are:
1. open edit mode (not of panel)
2. click on panel to open panel edit mode
3. click on the topbar "add widget" button
But even with this step it seem to happen only sometimes (less than before maybe) as it can be seen in the video.
Comment 7 Nate Graham 2024-06-12 16:18:26 UTC
Thanks. I'm trying the exact same thing and I can't get it to happen even once. Let's assume this got fixed in a later version of the code that's either in git master or the final release of Plasma 6.1.
Comment 8 dmatteo002 2024-06-14 18:55:11 UTC
Updated step:
1. open global Edit Mode
2. click on panel to open Panel Edit Mode
3. Click on "add widget" in the top global toolbar 

This seem to connected (I think) to the fact the when opening panel edit mode in this way (throught global edit mode), then panel edit mode is also not disposable by pressing ESC.
Comment 9 Nate Graham 2024-06-14 21:28:00 UTC
Created attachment 170506 [details]
Happened to me too

All right, I just got it to happen with those steps.
Comment 10 cwo 2024-06-18 12:54:35 UTC
It seems that this bug report at present mixes several issues:

1. The title is about having two ways to open the Widget Explorer - for panels, and for the desktop. This is intentional as they do different things.
2. The two ways work differently in many ways. See also #488571 and its comments for more inconsistencies
3. Sometimes, in particular if both the Widget Explorer and the Panel settings are open at the same time, the picture of the desktop becomes very small
4. Opening Widget Explorer should close the Panel Configuration (and the other way around, I presume?)

I'd like to argue against 4 first. It seems to me that a user who opens both the Widget Explorer and the Panel Settings is looking to setup multiple widgets on their panel, and will likely look to arrange them as well. Constantly leaving one mode or the other would mean lots of manual re-entering modes. Plus, there does not seem to be a conceptual reason why both couldn't be active at the same time, and if the user is done adding or rearranging, but still want the other mode active, they can always manually close things.

This means that the image of the desktop will sometimes be smaller (3). But I think it really looks weird in the screenshots here not because both modes are active, but because there's a lot of unused space. And this doesn't seem to happen in the default panel setup (bottom full-width panel); in that case, the full screen width gets used. So I would suggest that using all the available space would allow for a larger image of the desktop, and solve this. (It would still be rather tiny on a very small screen resolution , but I think it's unavoidable that this is going to happen sometimes. 

dmatteo, would that solve your issue?

I would also suggest editing the description to make it more clear what this bug is about.
Comment 11 dmatteo002 2024-06-20 08:55:34 UTC
So about the 4th point: my problem is not that it should close because now it doesn't; it is that that singular button sometimes it does close the panel configuration (expecially if i open directly the panel edit mode from the desktop) and sometimes it doesn't (it always does not close if I click on edit mode and then on panel edit mode, but only sometimes if i goes from desktop to panel edit mode). So it is about inconsistency about the use of a single button in equivalent situations.

About the other problem for which I'll open a bug report in the next days:
1. the panel configuration should be pushed to the side to leave as much space as possible to the desktop preview (like you mentioned).
2. the two "add widget" do different action but show same UI with no way to distinguish the two UI once opened. I think that it should at the very least add a different title to make the user expect slightly different result, else it may think that these two button are linked to same UI with same behaviour.
Comment 12 cwo 2024-06-20 10:00:36 UTC
I asked because your original report said "Both should close" as the expected result, so I assumed you had a particular preference toward that outcome, whereas my intuition would be that both should stay open.

The inconsistency seems like a valid issue, although you could make the argument that closing should not always do the same thing; see bug #487760 for the argument that closing Panel Configuration mode should leave Edit Mode active if it was active before opening Panel Configuration mode. (This is not the current behavior, which seems a bit arbitrary).

For more on inconsistent interactions between edit mode/panel configuration and the widget explorer/Add widget modes, see also bug #488571
Comment 13 Nate Graham 2024-06-25 20:42:02 UTC
*** Bug 488944 has been marked as a duplicate of this bug. ***
Comment 14 Nate Graham 2024-06-26 03:57:42 UTC
I cannot reproduce this at all anymore with current git master. I think there's a good chance it was fixed with some of the edit mode patches that went into Plasma 6.1.1.

Is anyone using Plasma 6.1.1 still able to reproduce the issue?
Comment 15 Bug Janitor Service 2024-07-11 03:47:08 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 16 dmatteo002 2024-07-11 06:37:14 UTC
I'm on plasma 6.1.1 and can still reproduce it. Nothing seem to have changed
Comment 17 dmatteo002 2024-07-11 06:38:45 UTC
Sorry wrong i'm on 6.1.2

FULL SYSTEM INFO
Operating System: Arch Linux 
KDE Plasma Version: 6.1.2
KDE Frameworks Version: 6.3.0
Qt Version: 6.8.0
Kernel Version: 6.9.8-arch1-1 (64-bit)
Graphics Platform: Wayland
Processors: 16 × AMD Ryzen 7 7735HS with Radeon Graphics
Comment 18 Nate Graham 2024-07-22 21:22:39 UTC
Still can't reproduce at all on current git master, which will become 6.2. Let's close it for now and re-open if you're still able to reproduce the issue once you've got 6.2 as well.