Bug 487438 - Add command pop-up broken
Summary: Add command pop-up broken
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: common (other bugs)
Version First Reported In: 24.02.2
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-23 18:29 UTC by Daniël van der Leij
Modified: 2024-08-05 22:06 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Screenshot showing the KDE Connect application with the broken pop-up (65.75 KB, image/png)
2024-05-23 18:29 UTC, Daniël van der Leij
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniël van der Leij 2024-05-23 18:29:16 UTC
Created attachment 169745 [details]
Screenshot showing the KDE Connect application with the broken pop-up

SUMMARY
The 'Add command' pop-up in the KDE Connect desktop application is broken. The pop-up does show, but is too small to contain all input fields, resulting in them appearing outside of the pop-up, overlaid by the save and cancel buttons.

STEPS TO REPRODUCE
1.  Open KDE Connect.
2.  Select a connected mobile device.
3.  Open the plugin settings
4.  Open the 'Run commands' plugin settings.
5.  Click on the 'Add command' button.

OBSERVED RESULT
The pop-up is too small and can't contain all input fields as a result.

EXPECTED RESULT
The pop-up is big enough to contain all input fields without any overlap.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:  Fedora 40
KDE Plasma Version: 6.0.4
KDE Frameworks Version: 6.2.0
Qt Version: 6.7.0

ADDITIONAL INFORMATION
See attatchment for visual example.
Comment 1 cwo 2024-08-01 18:00:34 UTC
Can reproduce with 24.05.2 on Tuxedo OS.

Operating System: TUXEDO OS 3
KDE Plasma Version: 6.1.3
KDE Frameworks Version: 6.4.0
Qt Version: 6.7.0
Kernel Version: 6.5.0-10043-tuxedo (64-bit)
Graphics Platform: Wayland
Comment 2 Bug Janitor Service 2024-08-01 22:41:35 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/707
Comment 3 Albert Vaca Cintora 2024-08-05 22:06:31 UTC
Git commit 19763dbf463cf97f186516670132e372c70a9f9b by Albert Vaca Cintora, on behalf of Christoph Wolk.
Committed on 05/08/2024 at 22:06.
Pushed by albertvaka into branch 'master'.

plugins/runcommand: use Kirigami.Dialog

The "Add Command" dialog in the settings for the Run Command plugin
looks rather broken at the moment, as the size is not explicitly set and
the default value ends up much smaller than the contents. It uses
QQC2.Dialog, even though the plugin makes heavy use of Kirigami. Using
Kirigami.dialog here would solve the sizing issue, and generally lead to
a more consistent interface.

This change makes the plugin use Kirigami.Dialog instead of QQC2.

M  +2    -1    plugins/runcommand/kdeconnect_runcommand_config.qml

https://invent.kde.org/network/kdeconnect-kde/-/commit/19763dbf463cf97f186516670132e372c70a9f9b