Bug 487404 - Discover build failure due to commit 370a22daaded23f4a754fb5168cb582ed34a9d14
Summary: Discover build failure due to commit 370a22daaded23f4a754fb5168cb582ed34a9d14
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Flatpak Backend (show other bugs)
Version: master
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 487532 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-05-23 02:54 UTC by Jonathan L Hanmann
Modified: 2025-01-25 14:42 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan L Hanmann 2024-05-23 02:54:23 UTC
SUMMARY

Discover won't build due to commit 370a22daaded23f4a754fb5168cb582ed34a9d14. Now expects support for function flatpak_transaction_add_rebase_and_uninstall. This function is not present in the Armbian/Ubuntu Noble flatpak dev library. That library is current at version 1.14.6-1. The 1.14.6 version of flatpak is fairly recent but does not provide that function never the less.

STEPS TO REPRODUCE
1. Build Discover on Armbian/Ubuntu Noble for ARM64 (can't verify this for non-ARM64 archs).

OBSERVED RESULT

[137/203] Building CXX object libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakSourcesBackend.cpp.o
[138/203] Building CXX object libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakTransactionThread.cpp.o
FAILED: libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakTransactionThread.cpp.o 
/usr/bin/c++ -DAPPSTREAM_NEW_POOL_API -DFLATPAK_LIST_UNUSED_REFS -DFLATPAK_VERBOSE_PROGRESS -DKCOREADDONS_LIB -DKPLUGINFACTORY_PLUGIN_CLASS_INTERNAL_NAME=flatpak_backend_factory -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_FOREACH -DQT_NO_KEYWORDS -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_QMLBUILTINS_LIB -DQT_QMLINTEGRATION_LIB -DQT_QML_LIB -DQT_STRICT_ITERATORS -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DTRANSLATION_DOMAIN=\"libdiscover\" -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dflatpak_backend_EXPORTS -I/home/jon/kde/build/discover/libdiscover/backends/FlatpakBackend -I/home/jon/kde/src/discover/libdiscover/backends/FlatpakBackend -I/home/jon/kde/build/discover/libdiscover/backends/FlatpakBackend/flatpak-backend_autogen/include -I/home/jon/kde/build/discover/libdiscover -I/home/jon/kde/src/discover/libdiscover -isystem /usr/include/aarch64-linux-gnu/qt6/QtCore -isystem /usr/include/aarch64-linux-gnu/qt6 -isystem /usr/lib/aarch64-linux-gnu/qt6/mkspecs/linux-g++ -isystem /usr/include/aarch64-linux-gnu/qt6/QtWidgets -isystem /usr/include/aarch64-linux-gnu/qt6/QtGui -isystem /usr/include/aarch64-linux-gnu/qt6/QtConcurrent -isystem /opt/Plasma6/include/KF6/KCoreAddons -isystem /opt/Plasma6/include/KF6/KConfig -isystem /opt/Plasma6/include/KF6/KConfigCore -isystem /opt/Plasma6/include/KF6/KIOGui -isystem /opt/Plasma6/include/KF6/KIOCore -isystem /opt/Plasma6/include/KF6/KIO -isystem /usr/include/aarch64-linux-gnu/qt6/QtNetwork -isystem /usr/include/aarch64-linux-gnu/qt6/QtDBus -isystem /opt/Plasma6/include/KF6/KService -isystem /opt/Plasma6/include/KF6/KIconThemes -isystem /usr/include/aarch64-linux-gnu/qt6/QtQml -isystem /usr/include/aarch64-linux-gnu/qt6/QtQmlIntegration -isystem /usr/include/aarch64-linux-gnu/qt6/QtQmlBuiltins -isystem /opt/Plasma6/include/KF6/KI18n -isystem /opt/Plasma6/include -isystem /opt/Plasma6/include/qcoro6 -isystem /opt/Plasma6/include/qcoro6/qcoro -isystem /opt/Plasma6/include/qcoro6/QCoro -isystem /usr/include/flatpak -isystem /usr/include/glib-2.0 -isystem /usr/lib/aarch64-linux-gnu/glib-2.0/include -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/ostree-1 -isystem /usr/include/gio-unix-2.0 -pipe -fno-operator-names -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Werror=init-self -Wvla -Wdate-time -Wsuggest-override -Wlogical-op -pedantic -Wzero-as-null-pointer-constant -Wmissing-include-dirs -fdiagnostics-color=always -fcoroutines -O2 -g -DNDEBUG -std=gnu++20 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fexceptions -pthread -MD -MT libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakTransactionThread.cpp.o -MF libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakTransactionThread.cpp.o.d -o libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakTransactionThread.cpp.o -c /home/jon/kde/src/discover/libdiscover/backends/FlatpakBackend/FlatpakTransactionThread.cpp
/home/jon/kde/src/discover/libdiscover/backends/FlatpakBackend/FlatpakTransactionThread.cpp: In member function ‘bool FlatpakTransactionThread::end_of_lifed_with_rebase(const char*, const char*, const char*, const char*, const char**)’:
/home/jon/kde/src/discover/libdiscover/backends/FlatpakBackend/FlatpakTransactionThread.cpp:418:26: error: ‘flatpak_transaction_add_rebase_and_uninstall’ was not declared in this scope; did you mean ‘flatpak_transaction_add_uninstall’?
  418 |     const auto correct = flatpak_transaction_add_rebase_and_uninstall(m_transaction, remote, rebased_to_ref, ref, nullptr, previous_ids, &localError);
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                          flatpak_transaction_add_uninstall
/home/jon/kde/src/discover/libdiscover/backends/FlatpakBackend/FlatpakTransactionThread.cpp:392:69: warning: unused parameter ‘reason’ [-Wunused-parameter]
  392 |                                                         const char *reason,
      |                                                         ~~~~~~~~~~~~^~~~~~
[139/203] Building CXX object libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakJobTransaction.cpp.o
[140/203] Building CXX object libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakResource.cpp.o
[141/203] Building CXX object libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakRefreshAppstreamMetadataJob.cpp.o
[142/203] Building CXX object libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakBackend.cpp.o
/home/jon/kde/src/discover/libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp: In member function ‘FlatpakRemote* FlatpakBackend::installSource(FlatpakResource*)’:
/home/jon/kde/src/discover/libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp:1975:14: warning: unused variable ‘remote’ [-Wunused-variable]
 1975 |     if (auto remote = flatpak_installation_get_remote_by_name(preferredInstallation(), resource->flatpakName().toUtf8().constData(), cancellable, nullptr)) {
      |              ^~~~~~
ninja: build stopped: subcommand failed.

EXPECTED RESULT

Successful build

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma:  Linux is Armbian/Ubuntu Noble with all latest updates. KDE Plasma built from master using kde-builder.
(available in About System)
KDE Plasma Version: 6.0.80 
KDE Frameworks Version:  6.3.0
Qt Version: 6.7.0

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2024-05-23 20:55:55 UTC
Will be fixed by https://invent.kde.org/plasma/discover/-/merge_requests/852.
Comment 2 Harald Sitter 2024-05-27 15:23:46 UTC
*** Bug 487532 has been marked as a duplicate of this bug. ***
Comment 3 Harald Sitter 2025-01-25 14:42:31 UTC
Feels like this was fixed a while ago already