Bug 487341 - The entire Appearance tab is non functional if used as a desktop applet
Summary: The entire Appearance tab is non functional if used as a desktop applet
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: Weather (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-21 23:53 UTC by Justin Zobel
Modified: 2024-05-22 20:57 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Zobel 2024-05-21 23:53:29 UTC
Not sure if it's possible to detect how the applet is being used, on a panel or on the desktop.

But the entire Appearance tab only affects the applet when it's on a panel and is irrelevant when used on the desktop.
Comment 1 Nate Graham 2024-05-22 19:08:19 UTC
We can detect this. Not sure how feasible it is to dynamically show or hide pages based on form factor though. Maybe.

You're right that everything on that page is useless when the widget is on the desktop: the settings only affect the icon version, and on the desktop it can't be resized small enough to become an icon.

Maybe that's the thing to change?
Comment 2 Bug Janitor Service 2024-05-22 20:40:55 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/587
Comment 3 Ismael Asensio 2024-05-22 20:45:45 UTC
(In reply to Nate Graham from comment #1)
> We can detect this. Not sure how feasible it is to dynamically show or hide
> pages based on form factor though. Maybe.

TIL, but it turns out it is quite easy. Plasmoid API (sometimes) rocks!

> Maybe that's the thing to change?

I wouldn't do this currently, because resizing to a smaller size than the implicit one can cause very ugly layout issues. 
If/when we get a full responsive layout, I wouldn't mind. Freedom of configuration! :)
Comment 4 Nate Graham 2024-05-22 20:49:03 UTC
Fair enough!
Comment 5 Ismael Asensio 2024-05-22 20:57:04 UTC
Git commit 139492f38f42ca18eb2f1c34c3a2aef9b230551c by Ismael Asensio.
Committed on 22/05/2024 at 20:53.
Pushed by iasensio into branch 'master'.

applets/weather: Hide Appearence settings when not in the panel

The settings in this category only apply to the CompactRepresentation,
so we can hide it from the config when not in the panel.
FIXED-IN: 6.1

M  +6    -0    applets/weather/package/contents/config/config.qml

https://invent.kde.org/plasma/kdeplasma-addons/-/commit/139492f38f42ca18eb2f1c34c3a2aef9b230551c