Created attachment 169541 [details] Clip job error message SUMMARY The parameters for ffmpeg are not passed on correctly even though the same work perfectly using ffmpeg in a terminal. STEPS TO REPRODUCE 1. Create a new Clip Job with Executable /usr/bin/ffmpeg and the following Arguments: -i {source} -crf 10 -vf "minterpolate=fps={param2}:mi_mode=mci:mc_mode=aobmc:me_mode=bidir:vsbmc=1" {output} 2. For Parameter 2 select Request option from list, name it "fps" and create list with the values 30, 60, 120, 240 3. Start the clip job on a video clip in the bin and select 60 for fps OBSERVED RESULT See atatchment EXPECTED RESULT For comparison enter this into a terminal: ffmpeg -i <input_file_name> -crf 10 -vf "minterpolate=fps=60:mi_mode=mci:mc_mode=aobmc:me_mode=bidir:vsbmc=1" <output_file_name> SOFTWARE/OS VERSIONS Linux: Pop!_OS 22.04 LTS KDE Frameworks Version: 6.0.0 Qt Version: 6.6.2 ADDITIONAL INFORMATION The Shift tool tip in the Arguments window refers to {%1}, {%2} and {%3} for parameter 1, parameter 2 and output filename. In fact it is {source}, {param1}, {param2} and {output}
It doesn't matter whether " is used or ' or any combination of them to encapsulate the minterpolate parameter string. The only change is what is displayed in the error message.
Leaving off the " fixed it
Do we have to update the documentation?
(In reply to emohr from comment #3) > Do we have to update the documentation? I think we should unless JBM changes the way " and/or ' are being handled. Interestingly enough, in most if not all forum posts with ffmpeg scripts or CL examples " or ' are used (see eyduh's example in the Telegram group). And it works in a terminal. Therefore my preference is to change it in Kdenlive so that the user can copy and paste ffmpeg CL examples. If that's an easy fix we leave the doc as is; if it's more complex and taking more time or not even worth JBM's time, let's update the doc. What we should definitely fix in Kdenlive is the extended tool tip as it is wrong.
Git commit 1b5e19edd534071bee69c1e1c29272b9fd9d666b by Eugen Mohr. Committed on 17/05/2024 at 16:22. Pushed by emohr into branch 'wotk/ClipJob_text-update'. ClipJob: correct and update info and whatsthis M +4 -4 src/dialogs/clipjobmanager.cpp M +1 -1 src/ui/clipjobmanager_ui.ui https://invent.kde.org/multimedia/kdenlive/-/commit/1b5e19edd534071bee69c1e1c29272b9fd9d666b
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/kdenlive/-/merge_requests/509
Git commit 8dad01d8f1e44f807195c439d33d8f9fd0a69d9c by Jean-Baptiste Mardelle. Committed on 19/05/2024 at 15:18. Pushed by mardelle into branch 'master'. Remove quotes in custom clip jobe, fix progress display M +11 -3 src/jobs/customjobtask.cpp M +1 -0 src/jobs/customjobtask.h https://invent.kde.org/multimedia/kdenlive/-/commit/8dad01d8f1e44f807195c439d33d8f9fd0a69d9c
Git commit 128d0eb018d78ca51bc03470a76f13288362c8f2 by Jean-Baptiste Mardelle. Committed on 21/05/2024 at 06:56. Pushed by mardelle into branch 'master'. Be more clever splitting custom ffmpeg commands around quotes M +19 -1 src/jobs/customjobtask.cpp https://invent.kde.org/multimedia/kdenlive/-/commit/128d0eb018d78ca51bc03470a76f13288362c8f2
This should now be fixed with my last commits in git master, please test.
(In reply to Jean-Baptiste Mardelle from comment #9) > This should now be fixed with my last commits in git master, please test. Test works: I added a new clip job with an ffmpeg command line parameter list enclosed with " and it works. The field Output File Extension expects an extension like mp4 or mkv, and throws an error if anything else is entered. I don't understand why this is needed as ffmpeg uses the same container as the input file. If the field is to have a file name suffix like "clip_job" or "0001" it doesn't work that way and would need to be renamed to Output File Suffix.
(In reply to Bernd from comment #10) > (In reply to Jean-Baptiste Mardelle from comment #9) > > This should now be fixed with my last commits in git master, please test. > > Test works: I added a new clip job with an ffmpeg command line parameter > list enclosed with " and it works. > > The field Output File Extension expects an extension like mp4 or mkv, and > throws an error if anything else is entered. I don't understand why this is > needed as ffmpeg uses the same container as the input file. If the field is > to have a file name suffix like "clip_job" or "0001" it doesn't work that > way and would need to be renamed to Output File Suffix. Tested on Windows 11
I noticed that every time a clip job is run for the same (original) clip an extra - (minus or dash) is added before the automatically created filename suffix "####". So, the first file generated by the clip job is called <original_filename>-0001.mp4, the second becomes <original_filename>--0002.mp4 and then <...>---0003.mp4 and so forth
Git commit 572a5bc9cbe4b658317b9f96341961bb0d2c3693 by Jean-Baptiste Mardelle. Committed on 23/05/2024 at 03:25. Pushed by mardelle into branch 'master'. Fix extra dash added to custom clip job output M +2 -2 src/jobs/customjobtask.cpp https://invent.kde.org/multimedia/kdenlive/-/commit/572a5bc9cbe4b658317b9f96341961bb0d2c3693
Git commit 152f36d89141813423f82b8ba57e0f9d42d57c4e by Jean-Baptiste Mardelle. Committed on 24/05/2024 at 07:35. Pushed by mardelle into branch 'release/24.05'. Remove quotes in custom clip jobe, fix progress display M +11 -3 src/jobs/customjobtask.cpp M +1 -0 src/jobs/customjobtask.h https://invent.kde.org/multimedia/kdenlive/-/commit/152f36d89141813423f82b8ba57e0f9d42d57c4e
Git commit 51d4aab3ba1fcbeefa55ff9e635b469758b7dfce by Jean-Baptiste Mardelle. Committed on 24/05/2024 at 07:38. Pushed by mardelle into branch 'release/24.05'. Fix extra dash added to custom clip job output M +2 -2 src/jobs/customjobtask.cpp https://invent.kde.org/multimedia/kdenlive/-/commit/51d4aab3ba1fcbeefa55ff9e635b469758b7dfce
Git commit f9b61a0adc6d89a4248a858b44b7a7c24537c803 by Jean-Baptiste Mardelle. Committed on 24/05/2024 at 07:37. Pushed by mardelle into branch 'release/24.05'. Be more clever splitting custom ffmpeg commands around quotes M +19 -1 src/jobs/customjobtask.cpp https://invent.kde.org/multimedia/kdenlive/-/commit/f9b61a0adc6d89a4248a858b44b7a7c24537c803