Bug 487023 - Group dialog is broken
Summary: Group dialog is broken
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (other bugs)
Version First Reported In: master
Platform: openSUSE Linux
: HI major
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-05-14 15:44 UTC by Fushan Wen
Modified: 2024-05-16 15:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fushan Wen 2024-05-14 15:44:55 UTC
plasmashell[28048]: file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/GroupDialog.qml:103:31: QML Component: Cannot create delegate
plasmashell[28048]: file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:45:5: Required property tasksRoot was not initialized
Comment 1 Bug Janitor Service 2024-05-14 17:39:20 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2248
Comment 2 Fushan Wen 2024-05-14 18:38:25 UTC
Git commit dbe20bc2479257d080a8c2846953073f55b73e44 by Fushan Wen.
Committed on 14/05/2024 at 17:32.
Pushed by fusionfuture into branch 'master'.

applets/taskmanager: make group dialog work again

It was missing a required property.

M  +1    -0    applets/taskmanager/package/contents/ui/GroupDialog.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/dbe20bc2479257d080a8c2846953073f55b73e44
Comment 3 Fushan Wen 2024-05-14 18:38:41 UTC
Git commit e602248f0ad22c737d49dc4fe16317a8a4371818 by Fushan Wen.
Committed on 14/05/2024 at 18:31.
Pushed by fusionfuture into branch 'master'.

appiumtests: add test for bug 487023

Make sure the group dialog works

M  +1    -0    appiumtests/CMakeLists.txt
A  +8    -0    appiumtests/applets/CMakeLists.txt
A  +103  -0    appiumtests/applets/taskmanager_bug487023test.py
M  +1    -1    appiumtests/desktop/desktoptest_testwindow.py
M  +4    -0    applets/taskmanager/package/contents/ui/ConfigBehavior.qml
M  +81   -77   applets/taskmanager/package/contents/ui/Task.qml
M  +5    -4    applets/taskmanager/plugin/smartlaunchers/smartlauncherbackend.cpp

https://invent.kde.org/plasma/plasma-desktop/-/commit/e602248f0ad22c737d49dc4fe16317a8a4371818
Comment 4 Marco Martin 2024-05-16 15:04:37 UTC
Git commit add32f482e668b3ecd170bf226cc99fd730d1b9a by Marco Martin.
Committed on 16/05/2024 at 15:04.
Pushed by mart into branch 'master'.

Fix group popup

Fix size hints of tasks to have a sensible size when in a popup

M  +3    -1    appiumtests/applets/taskmanager_bug487023test.py
M  +6    -4    applets/taskmanager/package/contents/ui/Task.qml
M  +5    -0    applets/taskmanager/package/contents/ui/code/layoutmetrics.js

https://invent.kde.org/plasma/plasma-desktop/-/commit/add32f482e668b3ecd170bf226cc99fd730d1b9a