Created attachment 169378 [details] Malloc style crash. SUMMARY I was making a roundtable, when adding STEPS TO REPRODUCE 1. Have an animated transform mask applied to an animated layer 2. Try to insert keyframes left or right on the painted layer, where there's also a keyframe on the transform mask. 3. This will sometimes cause a malloc, and sometimes an assert. SYSINFO: Krita Version: 5.3.0-prealpha (git f133846) Hidpi: true Qt Version (compiled): 5.15.7 Version (loaded): 5.15.7 OS Information Build ABI: x86_64-little_endian-lp64 Build CPU: x86_64 CPU: x86_64 Kernel Type: linux Kernel Version: 6.5.0-28-generic Pretty Productname: Ubuntu 20.04.6 LTS Product Type: ubuntu Product Version: 20.04 Desktop: Appimage build: No
Created attachment 169379 [details] Assert style crash.
It does not happen with the old 5.2.2 appimage: Krita Version: 5.2.2 Hidpi: true Qt Version (compiled): 5.15.7 Version (loaded): 5.15.7 OS Information Build ABI: x86_64-little_endian-lp64 Build CPU: x86_64 CPU: x86_64 Kernel Type: linux Kernel Version: 6.5.0-28-generic Pretty Productname: Ubuntu 23.10 Product Type: ubuntu Product Version: 23.10 Desktop: KDE Appimage build: Yes
Adding regression and release blocker tags, given animated transform mask refactor was backported to 5.2 already.
Hi, Wolthera! Could you please share the file you have issues with? I cannot reproduce the issue here locally :(
I've sent the file to you by mail. I seem to have made a small mistake in my description: It happens when you insert a keyframe column (thus on all visible layers), but it seems to be somewhat random when it happens, I just reproduced it when removing a keyframe...
Git commit 7541cfa30c29abc0c1050c6d3c3dab496995f572 by Dmitry Kazakov. Committed on 03/06/2024 at 17:32. Pushed by dkazakov into branch 'master'. Fix crash when adding a column with a locked layer selected 1) Select a frame on a locked layer on the timeline 2) Press "Insert column" The crash happened because calculateSelectionMetrics() would return an infinitly wide inverted range. Now the patch added an argument to ignore locked layers when it is necessary and added a validity check in KisAnimTimelineFramesView::insertKeyframes() M +8 -6 plugins/dockers/animation/KisAnimTimelineFramesView.cpp M +1 -1 plugins/dockers/animation/KisAnimTimelineFramesView.h https://invent.kde.org/graphics/krita/-/commit/7541cfa30c29abc0c1050c6d3c3dab496995f572
Git commit 9470e1a5173e725c6650d589dc807e628bd16043 by Dmitry Kazakov. Committed on 03/06/2024 at 17:34. Pushed by dkazakov into branch 'krita/5.2'. Fix crash when adding a column with a locked layer selected 1) Select a frame on a locked layer on the timeline 2) Press "Insert column" The crash happened because calculateSelectionMetrics() would return an infinitly wide inverted range. Now the patch added an argument to ignore locked layers when it is necessary and added a validity check in KisAnimTimelineFramesView::insertKeyframes() M +8 -6 plugins/dockers/animation/KisAnimTimelineFramesView.cpp M +1 -1 plugins/dockers/animation/KisAnimTimelineFramesView.h https://invent.kde.org/graphics/krita/-/commit/9470e1a5173e725c6650d589dc807e628bd16043