Bug 486888 - Restrictive RegEx when trying to add server
Summary: Restrictive RegEx when trying to add server
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (show other bugs)
Version: git master
Platform: Manjaro Linux
: NOR minor
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-11 13:56 UTC by amkreuzer
Modified: 2024-05-25 13:10 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/network/neochat/-/commit/8199653ddd992544c88480d3de98406bb0c6c9c5
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description amkreuzer 2024-05-11 13:56:48 UTC 
SUMMARY
Valid server address is being rejected by regular expression.
Same input works in Element matrix client.
Example input: matrix.fbi.h-da.de

CODE
src/qml/ServerComboBox.qml, line 133

STEPS TO REPRODUCE
1. Open Neochat
2. Explore Rooms
3. Open dropdown menu next to search
4. Add New Server
5. Type: matrix.fbi.h-da.de

OBSERVED RESULT

Input is being rejected 

EXPECTED RESULT

Valid server address can be entered

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Manjaro / X11
KDE Plasma Version:  5.27.1
KDE Frameworks Version:  5.115.0
Qt Version:  5.15.12
Comment 1 Bug Janitor Service 2024-05-24 15:08:09 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/1745
Comment 2 Tobias Fella 2024-05-25 13:10:51 UTC 
Git commit 8199653ddd992544c88480d3de98406bb0c6c9c5 by Tobias Fella.
Committed on 25/05/2024 at 13:00.
Pushed by tfella into branch 'master'.

Use simpler and less restrictive server url regex

The old regex was too restrictive. The new one will allow invalid urls, but we don't gain anything from preventing that

M  +1    -1    src/qml/ServerComboBox.qml

https://invent.kde.org/network/neochat/-/commit/8199653ddd992544c88480d3de98406bb0c6c9c5