Bug 486463 - Opening a link in a new tab automatically and unexpectedly switches you to that tab and show a popup largely blocking the tab switcher button to switch back
Summary: Opening a link in a new tab automatically and unexpectedly switches you to th...
Status: RESOLVED FIXED
Alias: None
Product: angelfish
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jonah Brüchert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-02 15:45 UTC by Bart Ribbers
Modified: 2024-05-08 05:12 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bart Ribbers 2024-05-02 15:45:31 UTC
When you hold any link a context menu will popup with an option to open the link in a new tab. Clicking that option then immediately moves you to that just opened tab. This was very unexpected for me, no other browser I ever used does this, and I'd like it to stay in the current active tab until I tell Angelfish to switch.

So when I want to switch back immediately this is made harder by the fact that a little snackbar message pops up saying the tab was opened (this whole message seems unnecessary to me, especially when you're already switched to the tab) blocking the clicking on the address bar or even the tab switcher.

I'd like to have it first of all not switch me automatically to the new tab and secondly not show the snackbar message as it's unnecessary and relaying information you already have as a user.
Comment 1 athozus 2024-05-05 15:48:31 UTC
There is already a setting for it.
Comment 2 Bart Ribbers 2024-05-05 16:45:59 UTC
Oh you're right, there is. Well then I'd say that settings needs to by off by default, because it's the opposite of every other browser really.

And the issue remains that it shows a popup telling you that the tab was opened, even though you just switched to it and already know. And it's blocking the bottom bar, it should really be placed above it if it's going to be shown at all.
Comment 3 Jonah Brüchert 2024-05-05 18:43:03 UTC
Are you interested in opening a merge request?
Comment 4 Jonah Brüchert 2024-05-06 10:57:42 UTC
Git commit a5af656b35ce9fd630c62eed7d88c4a492ace584 by Jonah Brüchert.
Committed on 06/05/2024 at 10:57.
Pushed by jbbgameich into branch 'master'.

Don't display error handler for HTTP status codes

Websites may need to handle them themselves.

M  +4    -4    angelfish-webapp/contents/ui/webapp.qml
M  +1    -1    lib/contents/ui/ErrorHandler.qml
M  +25   -18   lib/contents/ui/WebView.qml
M  +3    -1    src/contents/ui/desktop/desktop.qml
M  +3    -1    src/contents/ui/mobile.qml

https://invent.kde.org/network/angelfish/-/commit/a5af656b35ce9fd630c62eed7d88c4a492ace584
Comment 5 Jonah Brüchert 2024-05-06 11:00:00 UTC
Copy-pasted the wrong bug number there, sorry
Comment 6 Jonah Brüchert 2024-05-06 11:02:34 UTC
Git commit a8663e423a41a8ffbc848cdecec1a50756f9b18d by Jonah Brüchert.
Committed on 06/05/2024 at 11:02.
Pushed by jbbgameich into branch 'master'.

Default to not switching to new tabs

M  +1    -1    lib/angelfishsettings.kcfg

https://invent.kde.org/network/angelfish/-/commit/a8663e423a41a8ffbc848cdecec1a50756f9b18d
Comment 7 Kevin Kofler 2024-05-08 05:12:08 UTC
> Default to not switching to new tabs

I am not convinced just changing the default for this flag is the proper fix for the issue, unless its behavior has changed since last time I tried it.

I have found this behavior of links opening in new tabs activating that tab annoying as well, so I tried to run with "switchToNewTab=false" for a while. I have given up on it because I actually found it MORE annoying. The issue is that this also applies not only to tabs opened from links, but also to tabs that I open explicitly from the Angelfish menus. And those tabs, I most definitely DO want to switch to, because that is what I opened them for. So with "switchToNewTab=false", I have to then do 2 extra touches to actually switch to the tab I just opened before entering the URL in it.

So what I would like to see as the default, or at least as an option, is a mode where switching to new tabs is disabled for tabs opened from links (either because the website says so or because I picked "Open in new tab"), but enabled for tabs opened explicitly through the "new tab" button in the Angelfish UI.