Bug 485918 - Next and Back arrows are wrong for RTL language
Summary: Next and Back arrows are wrong for RTL language
Status: RESOLVED FIXED
Alias: None
Product: Welcome Center
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: rtl
Depends on:
Blocks:
 
Reported: 2024-04-21 18:44 UTC by Zayed Al-Saidi
Modified: 2024-04-21 20:53 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.5
Sentry Crash Report:


Attachments
Current status as of 20-April-2024 (170.66 KB, image/png)
2024-04-21 18:44 UTC, Zayed Al-Saidi
Details
the correct way for RtL languages (157.58 KB, image/png)
2024-04-21 18:45 UTC, Zayed Al-Saidi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Zayed Al-Saidi 2024-04-21 18:44:16 UTC
Created attachment 168758 [details]
Current status as of 20-April-2024

The next arrow and the back arrow are wrong for RTL languages. They should be mirrored.

Please refer to the screenshot for the current status.
I made a mockup of the correct way for RTL language in the second image.

I'm using neon unstable git20240420
Comment 1 Zayed Al-Saidi 2024-04-21 18:45:09 UTC
Created attachment 168759 [details]
the correct way for RtL languages
Comment 2 Nate Graham 2024-04-21 19:04:15 UTC
Can confirm. How embarrassing; this is basic RTL language stuff. Will fix ASAP.
Comment 3 Bug Janitor Service 2024-04-21 19:06:49 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-welcome/-/merge_requests/154
Comment 4 Nate Graham 2024-04-21 20:53:06 UTC
Git commit 66227074420ca9f37174f5df18ac0dd97d709660 by Nate Graham.
Committed on 21/04/2024 at 19:24.
Pushed by olib into branch 'master'.

Fix RTL footer buttons and navigation

These are custom UI elements so we have to handle RTL languages
ourselves. Previously we weren't; now we are.
FIXED-IN: 6.0.5

M  +20   -4    src/qml/footers/FooterDefault.qml
M  +1    -1    src/qml/footers/FooterUpdate.qml

https://invent.kde.org/plasma/plasma-welcome/-/commit/66227074420ca9f37174f5df18ac0dd97d709660
Comment 5 Oliver Beard 2024-04-21 20:53:22 UTC
Git commit 02313ebd3f26d43f31c9721ed0486e4b846a4da0 by Oliver Beard, on behalf of Nate Graham.
Committed on 21/04/2024 at 20:53.
Pushed by olib into branch 'Plasma/6.0'.

Fix RTL footer buttons and navigation

These are custom UI elements so we have to handle RTL languages
ourselves. Previously we weren't; now we are.
FIXED-IN: 6.0.5


(cherry picked from commit 66227074420ca9f37174f5df18ac0dd97d709660)

M  +20   -4    src/contents/ui/footers/FooterDefault.qml
M  +1    -1    src/contents/ui/footers/FooterUpdate.qml

https://invent.kde.org/plasma/plasma-welcome/-/commit/02313ebd3f26d43f31c9721ed0486e4b846a4da0