Bug 485688 - ActionTextField has a larger height than other controls
Summary: ActionTextField has a larger height than other controls
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2024-04-17 17:57 UTC by Fushan Wen
Modified: 2024-05-04 01:26 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/libplasma/-/commit/75d6c15bf0d3a31529e645a7f693c3d507a52a07
Version Fixed In: 6.1

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Fushan Wen 2024-04-17 17:57:35 UTC 
After the radius patch, ActionTextField now has a larger height, which can be observed in KRunner and Kickoff.
Comment 1 Fushan Wen 2024-04-27 03:21:11 UTC 
Regression from https://invent.kde.org/plasma/libplasma/-/merge_requests/1096
Comment 2 Bug Janitor Service 2024-04-27 03:57:05 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1110
Comment 3 Bug Janitor Service 2024-04-27 04:26:23 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1111
Comment 4 Fushan Wen 2024-04-28 00:53:02 UTC 
Git commit 75d6c15bf0d3a31529e645a7f693c3d507a52a07 by Fushan Wen.
Committed on 27/04/2024 at 03:49.
Pushed by fusionfuture into branch 'master'.

lineedit.svg: align heights of button and text field

The margins affects the height of a text field. To make sure the new
radius doesn't cause discrepancy between the button and the text field,
shrink the margin by 2 units.

Amends 69e1d4e72c9ac5b84b53a2b8708d248593792304
FIXED-IN: 6.1

M  +-    --    src/desktoptheme/breeze/widgets/lineedit.svg

https://invent.kde.org/plasma/libplasma/-/commit/75d6c15bf0d3a31529e645a7f693c3d507a52a07
Comment 5 Fushan Wen 2024-05-04 01:26:11 UTC 
Git commit 6dfc5d043bfe81faa44b2caf7b0327289f001344 by Fushan Wen.
Committed on 03/05/2024 at 02:16.
Pushed by fusionfuture into branch 'master'.

autotests: add test for bug 485688

Make sure the text field and the button have (almost) the same height

M  +0    -1    .kde-ci.yml
M  +3    -1    autotests/CMakeLists.txt
A  +10   -0    autotests/declarativetests/CMakeLists.txt
A  +31   -0    autotests/declarativetests/bug485688.qml     [License: LGPL(v2.1+)]
A  +35   -0    autotests/declarativetests/qmltest.cpp     [License: LGPL(v2.1+)]

https://invent.kde.org/plasma/libplasma/-/commit/6dfc5d043bfe81faa44b2caf7b0327289f001344