Bug 485637 - Wrong account is shown as the booster
Summary: Wrong account is shown as the booster
Status: RESOLVED FIXED
Alias: None
Product: Tokodon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-16 15:43 UTC by Joshua Goins
Modified: 2024-05-25 11:41 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Goins 2024-04-16 15:43:15 UTC
I've been seeing this, I wonder if it's due to my fallback code not working. I regularly see boosts from people I don't follow, but this is a local issue. Scrolling to the same post on Mastodon web shows the actual boosting account.
Comment 1 Joshua Goins 2024-05-25 11:31:57 UTC
Git commit 9e67080e6eead8bcdd6d7f8cabab65268bb324f2 by Joshua Goins, on behalf of Jyrki Gadinger.
Committed on 25/05/2024 at 11:31.
Pushed by redstrate into branch 'master'.

Fix wrong "%1 boosted" label on certain posts

The wrong author identity was selected when the boosted toot was a reply to their own post.

This is now fixed by swapping the `if`-conditions in the `identity` property to be inline with the other conditions in this file (i.e. `root.isBoosted`/`root.isReply`).

M  +4    -4    src/content/ui/PostDelegate/UserInteractionLabel.qml

https://invent.kde.org/network/tokodon/-/commit/9e67080e6eead8bcdd6d7f8cabab65268bb324f2
Comment 2 Joshua Goins 2024-05-25 11:41:22 UTC
Git commit 0003fa67e0c2a309f1b7f727ef15d635da6663dd by Joshua Goins.
Committed on 25/05/2024 at 11:41.
Pushed by redstrate into branch 'release/24.05'.

Fix wrong "%1 boosted" label on certain posts

The wrong author identity was selected when the boosted toot was a reply to their own post.

This is now fixed by swapping the `if`-conditions in the `identity` property to be inline with the other conditions in this file (i.e. `root.isBoosted`/`root.isReply`).

(cherry picked from commit 9e67080e6eead8bcdd6d7f8cabab65268bb324f2)

M  +4    -4    src/content/ui/PostDelegate/UserInteractionLabel.qml

https://invent.kde.org/network/tokodon/-/commit/0003fa67e0c2a309f1b7f727ef15d635da6663dd